-
Notifications
You must be signed in to change notification settings - Fork 62
Add additionalContext support to MLXLanguageModel
#145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mattt
merged 9 commits into
huggingface:main
from
noorbhatia:mlx-custom-generation-options
Mar 24, 2026
+267
−78
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d27310d
Add additionalContext support to MLXLanguageModel
noorbhatia a08700a
Fix merge conflict resolution
mattt edcc986
Incorporate feedback from review
mattt 38ecb34
Add userInputProcessing property to MLX custom generation options
mattt 9091dac
Group KV cache generation options into struct
mattt 0646e79
Improve ergnomics of resize processor at call site
mattt e90669b
Fix compiler errors due to JSONValue ambiguity
mattt bea4b35
Update expectation for MLX image processing test
mattt b834891
Incorporate feedback from review
mattt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| import enum JSONSchema.JSONValue | ||
|
|
||
| /// A type-safe representation of JSON values used by AnyLanguageModel APIs. | ||
| public typealias JSONValue = JSONSchema.JSONValue |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.