Preserve named string enum dependencies in schema conversion#149
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a schema-conversion edge case where named string enums (typically coming from $defs / dependencies) were not preserved as named enum schemas during conversion to FoundationModels.DynamicGenerationSchema, causing reference resolution to fail and leading to silent placeholder outputs (Issue #146).
Changes:
- Update JSONSchema →
FoundationModels.DynamicGenerationSchemaconversion to emit a named string-enum schema when a string schema withenumvalues is converted with aname. - Add a regression test ensuring a referenced, named string-enum dependency can be used to build a
FoundationModels.GenerationSchemawithout throwing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Sources/AnyLanguageModel/Models/SystemLanguageModel.swift |
Preserves named string-enum dependencies by converting them into named anyOf: [String] schemas, enabling reference resolution. |
Tests/AnyLanguageModelTests/DynamicSchemaConversionTests.swift |
Adds a regression test covering a named string enum dependency referenced from a root schema. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146