Fix np.bool8 error for NumPy 1.24+ compatibility#637
Open
kohankhaki wants to merge 1 commit intohuggingface:mainfrom
Open
Fix np.bool8 error for NumPy 1.24+ compatibility#637kohankhaki wants to merge 1 commit intohuggingface:mainfrom
kohankhaki wants to merge 1 commit intohuggingface:mainfrom
Conversation
Author
|
@simoninithomas Hi, I have opened this PR on one of the notebooks. It is an easy fix to a version. I'd appreciate this if you can take a look into this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Add compatibility patch for deprecated
np.bool8in NumPy ≥1.24Summary
This PR addresses a compatibility issue with newer versions of NumPy (1.24+) by defining
np.bool8as an alias tonp.bool_when it is missing. This fixes runtime errors in environments that still referencenp.bool8.Problem
When using NumPy ≥1.24, the following error is raised:
This is because of the removal of the
np.bool8alias, which some environments or wrappers (e.g., fromgym-gamesor older Gym integrations) still use.Solution
This PR adds the following patch at runtime:
References