-
Notifications
You must be signed in to change notification settings - Fork 52
Refactor variant handling and add CUDA fallback #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
202a142
Refactor variant handling and add CUDA fallback
danieldk 38696ec
Refactor variant handling and add CUDA fallback
danieldk 88ad4e4
Switch around cxx11 condition to support tagless build variant
danieldk 81bbbd2
Make `kernels versions` more informative
danieldk 0a4b48e
Move backend/variant regexes to their classes
danieldk 202712c
Type fixes
danieldk 5be720f
Improve error handling
danieldk 6bcf4e0
Add tvm-ffi variant strings for testing
danieldk d4cfe1f
Formatting
danieldk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,44 +1,31 @@ | ||
| from importlib.util import find_spec | ||
| from pathlib import Path | ||
|
|
||
| from huggingface_hub import HfApi | ||
|
|
||
| from kernels._versions import _get_available_versions | ||
| from kernels.utils import _build_variants, _get_hf_api | ||
| from kernels.variants import BUILD_VARIANT_REGEX | ||
| from kernels.utils import _get_hf_api | ||
| from kernels.variants import ( | ||
| get_variants, | ||
| resolve_variants, | ||
| ) | ||
|
|
||
|
|
||
| def print_kernel_versions(repo_id: str): | ||
| api = _get_hf_api() | ||
|
|
||
| if find_spec("torch") is None: | ||
| # Do not mark compatible variants when Torch is not available. | ||
| compatible_variants = set() | ||
| else: | ||
| compatible_variants = set(_build_variants(None)) | ||
|
|
||
| versions = _get_available_versions(repo_id).items() | ||
| if not versions: | ||
| print(f"Repository does not support kernel versions: {repo_id}") | ||
| return | ||
|
|
||
| for version, ref in sorted(versions, key=lambda x: x[0]): | ||
| variants = get_variants(api, repo_id=repo_id, revision=ref.ref) | ||
| resolved = resolve_variants(variants, None) | ||
| best = resolved[0] if resolved else None | ||
| resolved_set = set(resolved) | ||
| print(f"Version {version}: ", end="") | ||
sayakpaul marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| variants = [ | ||
| f"{variant} ✅" if variant in compatible_variants else f"{variant}" | ||
| for variant in _get_build_variants(api, repo_id, ref.ref) | ||
| variant_strs = [ | ||
| ( | ||
| f"✅ {variant.variant_str} ({'compatible, preferred' if variant == best else 'compatible'})" | ||
| if variant in resolved_set | ||
| else f"{variant.variant_str}" | ||
| ) | ||
| for variant in variants | ||
| ] | ||
| print(", ".join(variants)) | ||
|
|
||
|
|
||
| def _get_build_variants(api: "HfApi", repo_id: str, revision: str) -> list[str]: | ||
| variants = set() | ||
| for filename in api.list_repo_files(repo_id, revision=revision): | ||
| path = Path(filename) | ||
| if len(path.parts) < 2 or path.parts[0] != "build": | ||
| continue | ||
|
|
||
| match = BUILD_VARIANT_REGEX.match(path.parts[1]) | ||
| if match: | ||
| variants.add(path.parts[1]) | ||
| return sorted(variants) | ||
| print(", ".join(variant_strs)) | ||
sayakpaul marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah lovely!