feat: add offset mapping support for WordPiece tokenizers#17
Open
dkhokhlov wants to merge 1 commit intohuggingface:mainfrom
Open
feat: add offset mapping support for WordPiece tokenizers#17dkhokhlov wants to merge 1 commit intohuggingface:mainfrom
dkhokhlov wants to merge 1 commit intohuggingface:mainfrom
Conversation
dkhokhlov
commented
Dec 11, 2025
dkhokhlov
commented
- Add offset_mapping field to Encoding interface
- Implement calculateWordPieceOffsets utility for character position tracking
- Add return_offsets_mapping option to Tokenizer.encode() method
- Handle WordPiece subword tokens (## prefix) correctly
- Map special tokens to [0,0] offsets as per HF standard
- Add error handling for unsupported model types (BPE, Unigram)
dkhokhlov
force-pushed
the
add_offset_mapping_support_for_wordpiece_tokenizers
branch
from
7da8fc1 to
0a53799
Compare
dkhokhlov
force-pushed
the
add_offset_mapping_support_for_wordpiece_tokenizers
branch
from
0a53799 to
ad96967
Compare
Collaborator
|
Thanks for the PR! Could you add a lengthy set of unit tests to make sure this matches the rust library? Also, did you reference the rust library when implementing the PR? It's usually easier to align with their implementation to make sure it matches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.