Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
as discussed on slack, let's separate the PR into multiple ones :-) For def test_ignores_other_decorators(self):
""" what this really want to check (and maybe also why it should be the expected output you specified) """
path = self._write_temp("@dataclass\nclass Baz:\n pass\n")
names = _get_auto_docstring_names(path)
self.assertEqual(names, set())(I don't mind AI generate docstring, as long as you have an 👀 reading it first 🙏 ) For some tests, we could guess what they are from the test body, but it's not always clear. (I know, we rarely have docstring in test methods ... in general 😢 ) |
|
splited out the doctsring refactoring in a different PR #45009 |
fee57c5 to
6ae3f7c
Compare
|
splitted out changes to check_repo in #45012 |
ydshieh
left a comment
There was a problem hiding this comment.
Very nice and thank you for the iteration! Going to 🚀
What does this PR do?
make check-repocan be quite slow, this patch adds file-level cache to speed up checks.We get up to a 27x speedup