Skip to content

fix: glm5 inference bug#45016

Closed
inisis wants to merge 4 commits intohuggingface:mainfrom
inisis:main
Closed

fix: glm5 inference bug#45016
inisis wants to merge 4 commits intohuggingface:mainfrom
inisis:main

Conversation

@inisis
Copy link
Copy Markdown
Contributor

@inisis inisis commented Mar 26, 2026

What does this PR do?

Fixes #44960

Code Agent Policy

The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.

PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.

This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read CONTRIBUTING.md.

  • I confirm that this is not a pure code agent PR.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@inisis inisis mentioned this pull request Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: glm_moe_dsa

@IlyasMoutawwakil
Copy link
Copy Markdown
Member

thanks for the fix @inisis ! can you please explain in the PR what it consists of ? is it just a mismatch with the original implementation ?

@inisis
Copy link
Copy Markdown
Contributor Author

inisis commented Mar 26, 2026

@IlyasMoutawwakil this pr fixes a bug in glm5 modeling, the mla should use a non neox_style rope while indexer should use a neox_style rope, but now they are all neox_style rope, and this will result in incorrect output.

@IlyasMoutawwakil IlyasMoutawwakil removed the request for review from ArthurZucker March 26, 2026 11:42
@IlyasMoutawwakil
Copy link
Copy Markdown
Member

i see someone from @zai-org also opened a PR in #45017 and arthur is already reviewing it.

@inisis
Copy link
Copy Markdown
Contributor Author

inisis commented Mar 26, 2026

OK, I will close it, and work on that pr, thanks for your time! @IlyasMoutawwakil

@inisis inisis closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GLM5

2 participants