[fix] BC for legacy configs with top-level rope_theta when rope_parameters is set via rope_scaling#45036
Open
matdou wants to merge 1 commit intohuggingface:mainfrom
Open
[fix] BC for legacy configs with top-level rope_theta when rope_parameters is set via rope_scaling#45036matdou wants to merge 1 commit intohuggingface:mainfrom
matdou wants to merge 1 commit intohuggingface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #45030
Configs like
tiny-random/glm-4vstorerope_thetaat the top level ofconfig.jsonalongside arope_scalingdict (legacy format). For config classes that don't declarerope_parametersas a dataclass field (e.g.Glm4vConfig),convert_rope_params_to_dictis skipped becausehasattr(self, "rope_parameters")isFalsebefore the kwargs loop.During initialization, the kwargs loop sets
self.rope_parametersvia therope_scalingproperty setter — but withoutrope_theta— and assignsself.rope_thetaas a separate attribute. When@strict'svalidate_roperuns after__init__, it expectsrope_thetainsiderope_parametersand raises aKeyError.Fix
Add a normalization step in
PreTrainedConfig.__post_init__after the kwargs loop:rope_parametersis a dictrope_thetais missing from itself.rope_thetaexists"default"→ Inject
rope_thetaintorope_parameters.This ensures backward compatibility with legacy configs while keeping behavior
unchanged for newer ones.
Why this is safe
rope_parametersas a field → go throughconvert_rope_params_to_dict, orrope_thetainsiderope_parametersmodeling_rope_utils.pyuntouched)Test
Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read
CONTRIBUTING.md.Before submitting
Pull Request section?
to it if that's the case. tiny-random glm4v configuration can't load due to config validation changes #45030
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
Tagging: @ArthurZucker @Cyrilvallez (model loading)