Skip to content

Llama3 video fix#45040

Open
sywangyi wants to merge 2 commits intohuggingface:mainfrom
sywangyi:llama3_video_fix
Open

Llama3 video fix#45040
sywangyi wants to merge 2 commits intohuggingface:mainfrom
sywangyi:llama3_video_fix

Conversation

@sywangyi
Copy link
Copy Markdown
Contributor

when running tests/models/video_llama_3/test_modeling_video_llama_3.py::VideoLlama3IntegrationTest all fail cause by lm_head.weight is missing.

Signed-off-by: Wang, Yi <yi.a.wang@intel.com>
Signed-off-by: Wang, Yi <yi.a.wang@intel.com>
@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: video_llama_3

@ydshieh
Copy link
Copy Markdown
Collaborator

ydshieh commented Mar 27, 2026

@zucchini-nlp

The current failure (on main) is from

Untangle config inheritance (#41541)

For this PR, it fixed the CI, but I don't know if it's the best / correct way.

Could you check, taking the above context.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the model ties weights by default always or some ckpt leave untied? We need to change the default if it's always tied, that should work for most cases

Copy link
Copy Markdown
Collaborator

@ydshieh ydshieh Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we should change code defaults according "if there are checkpoints on the hub" untied.

Does the PR (on Jan) change some thing that won't load the tie_weight attribute from the text model correctly like before?

Copy link
Copy Markdown
Member

@zucchini-nlp zucchini-nlp Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the config attr in Jan, it didn't exist before (but the base class had default True) and I might have added it with wrong default ig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants