Fix pandas_ta bbands function parameters across all controllers#95
Open
hanwencheng wants to merge 2 commits intohummingbot:mainfrom
Open
Fix pandas_ta bbands function parameters across all controllers#95hanwencheng wants to merge 2 commits intohummingbot:mainfrom
hanwencheng wants to merge 2 commits intohummingbot:mainfrom
Conversation
- Replace incorrect 'std=' parameter with 'lower_std=' and 'upper_std='
- Update BBP column references to use correct format: BBP_{length}_{lower_std}_{upper_std}
Affected files:
- bots/controllers/generic/quantum_grid_allocator.py
- bots/controllers/directional_trading/macd_bb_v1.py
- bots/controllers/directional_trading/bollinger_v1.py
- bots/controllers/directional_trading/dman_v3.py
- bots/controllers/directional_trading/bollingrid.py
This fixes KeyError exceptions when trying to access BBP columns that
weren't properly created due to incorrect pandas_ta.bbands() parameters.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
@rapcmia @david-hummingbot can you tag the dev working on the upgrade to validate this fix? |
Contributor
|
@lgrawet Can you check this PR? |
|
Hi @david-hummingbot and @hanwencheng, it looks good to me excepted for dman_v3.py where a fix is also required in |
Author
|
Thanks, updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected files:
This fixes KeyError exceptions when trying to access BBP columns that weren't properly created due to incorrect pandas_ta.bbands() parameters.