Wrap computer action param serialization failures

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/async_manager/computer_action.py

@@ -91,7 +91,15 @@ async def _execute_request(
             )
 
         if isinstance(params, BaseModel):
-            payload = params.model_dump(by_alias=True, exclude_none=True)
+            try:
+                payload = params.model_dump(by_alias=True, exclude_none=True)
+            except HyperbrowserError:
+                raise
+            except Exception as exc:
+                raise HyperbrowserError(
+                    "Failed to serialize computer action params",
+                    original_error=exc,
+                ) from exc
         else:
             payload = params
 

hyperbrowser/client/managers/sync_manager/computer_action.py

@@ -91,7 +91,15 @@ def _execute_request(
             )
 
         if isinstance(params, BaseModel):
-            payload = params.model_dump(by_alias=True, exclude_none=True)
+            try:
+                payload = params.model_dump(by_alias=True, exclude_none=True)
+            except HyperbrowserError:
+                raise
+            except Exception as exc:
+                raise HyperbrowserError(
+                    "Failed to serialize computer action params",
+                    original_error=exc,
+                ) from exc
         else:
             payload = params
 

tests/test_computer_action_manager.py

@@ -2,6 +2,7 @@
 from types import SimpleNamespace
 
 import pytest
+from pydantic import BaseModel
 
 from hyperbrowser.client.managers.async_manager.computer_action import (
     ComputerActionManager as AsyncComputerActionManager,
@@ -160,3 +161,79 @@ async def run() -> None:
             await manager.screenshot(_SessionId("sess_123"))
 
     asyncio.run(run())
+
+
+def test_sync_computer_action_manager_wraps_param_serialization_errors():
+    class _BrokenParams(BaseModel):
+        def model_dump(self, *args, **kwargs):  # type: ignore[override]
+            _ = args
+            _ = kwargs
+            raise RuntimeError("broken model_dump")
+
+    manager = SyncComputerActionManager(_DummyClient())
+    session = SimpleNamespace(computer_action_endpoint="https://example.com/cua")
+
+    with pytest.raises(
+        HyperbrowserError, match="Failed to serialize computer action params"
+    ) as exc_info:
+        manager._execute_request(session, _BrokenParams())  # type: ignore[arg-type]
+
+    assert isinstance(exc_info.value.original_error, RuntimeError)
+
+
+def test_sync_computer_action_manager_preserves_hyperbrowser_param_serialization_errors():
+    class _BrokenParams(BaseModel):
+        def model_dump(self, *args, **kwargs):  # type: ignore[override]
+            _ = args
+            _ = kwargs
+            raise HyperbrowserError("custom model_dump failure")
+
+    manager = SyncComputerActionManager(_DummyClient())
+    session = SimpleNamespace(computer_action_endpoint="https://example.com/cua")
+
+    with pytest.raises(
+        HyperbrowserError, match="custom model_dump failure"
+    ) as exc_info:
+        manager._execute_request(session, _BrokenParams())  # type: ignore[arg-type]
+
+    assert exc_info.value.original_error is None
+
+
+def test_async_computer_action_manager_wraps_param_serialization_errors():
+    class _BrokenParams(BaseModel):
+        def model_dump(self, *args, **kwargs):  # type: ignore[override]
+            _ = args
+            _ = kwargs
+            raise RuntimeError("broken model_dump")
+
+    manager = AsyncComputerActionManager(_DummyClient())
+    session = SimpleNamespace(computer_action_endpoint="https://example.com/cua")
+
+    async def run() -> None:
+        with pytest.raises(
+            HyperbrowserError, match="Failed to serialize computer action params"
+        ) as exc_info:
+            await manager._execute_request(session, _BrokenParams())  # type: ignore[arg-type]
+        assert isinstance(exc_info.value.original_error, RuntimeError)
+
+    asyncio.run(run())
+
+
+def test_async_computer_action_manager_preserves_hyperbrowser_param_serialization_errors():
+    class _BrokenParams(BaseModel):
+        def model_dump(self, *args, **kwargs):  # type: ignore[override]
+            _ = args
+            _ = kwargs
+            raise HyperbrowserError("custom model_dump failure")
+
+    manager = AsyncComputerActionManager(_DummyClient())
+    session = SimpleNamespace(computer_action_endpoint="https://example.com/cua")
+
+    async def run() -> None:
+        with pytest.raises(
+            HyperbrowserError, match="custom model_dump failure"
+        ) as exc_info:
+            await manager._execute_request(session, _BrokenParams())  # type: ignore[arg-type]
+        assert exc_info.value.original_error is None
+
+    asyncio.run(run())