Skip to content

Session replay event display #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MikeShi42 wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −1
Draft

Session replay event display #1807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f18531
fix: mark session replay event sub-panel as nested to fix tab and clo…
cursoragent Feb 25, 2026
ce404c5
fix: add withOverlay prop to allow overlay on nested session replay s…
cursoragent Feb 26, 2026
786bff6
Merge branch 'main' into cursor/HDX-3481-session-replay-event-display…
MikeShi42 Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/app/src/SessionSubpanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,12 @@ export default function SessionSubpanel({
const [rowId, setRowId] = useState<string | undefined>(undefined);
const [aliasWith, setAliasWith] = useState<WithClause[]>([]);

useEffect(() => {
return () => {
setDrawerOpen(false);
};
}, [setDrawerOpen]);

const [tsQuery, setTsQuery] = useQueryState(
'ts',
parseAsInteger.withOptions({ history: 'replace' }),
Expand Down Expand Up @@ -467,6 +473,8 @@ export default function SessionSubpanel({
source={traceSource}
rowId={rowId}
aliasWith={aliasWith}
isNestedPanel={true}
withOverlay={true}
onClose={() => {
setDrawerOpen(false);
setRowId(undefined);
Expand Down
4 changes: 3 additions & 1 deletion packages/app/src/components/DBRowSidePanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ type DBRowSidePanelProps = {
aliasWith?: WithClause[];
onClose: () => void;
isNestedPanel?: boolean;
withOverlay?: boolean;
breadcrumbPath?: BreadcrumbPath;
onBreadcrumbClick?: BreadcrumbNavigationCallback;
};
Expand Down Expand Up @@ -527,6 +528,7 @@ export default function DBRowSidePanelErrorBoundary({
aliasWith,
source,
isNestedPanel,
withOverlay,
breadcrumbPath = [],
onBreadcrumbClick,
}: DBRowSidePanelProps) {
Expand Down Expand Up @@ -566,7 +568,7 @@ export default function DBRowSidePanelErrorBoundary({
<Drawer
opened={rowId != null}
withCloseButton={false}
withOverlay={!isNestedPanel}
withOverlay={withOverlay ?? !isNestedPanel}
onClose={() => {
if (!subDrawerOpen) {
_onClose();
Expand Down
Loading