Skip to content

feat(delta): add clear selection button for Event Deltas heatmap#1967

Draft
alex-fedotyev wants to merge 4 commits intomainfrom
cursor/HDX-3693-event-deltas-clear-selection-d108
Draft

feat(delta): add clear selection button for Event Deltas heatmap#1967
alex-fedotyev wants to merge 4 commits intomainfrom
cursor/HDX-3693-event-deltas-clear-selection-d108

Conversation

@alex-fedotyev
Copy link
Contributor

@alex-fedotyev alex-fedotyev commented Mar 23, 2026

Summary

Adds a clear-selection affordance to Event Deltas and ensures clearing selection resets both the comparison mode and the heatmap's visual selection overlay.

What's included

  • DBDeltaChart
    • Adds onClearSelection callback prop
    • Shows IconX clear button in legend while selection is active
  • DBSearchHeatmapChart
    • Wires clear action to reset xMin/xMax/yMin/yMax
    • Uses a clearSelectionVersion signal for chart-side visual reset
    • Ensures table filter actions also trigger selection clear
  • DBHeatmapChart
    • Accepts clearSelectionVersion
    • Clears local selection UI and persisted uPlot selection rectangle when clear is triggered

Follow-up CI fix

  • Removed a duplicate clearSelection declaration introduced during branch consolidation, which caused TypeScript/lint failures.

How to test

  1. In Event Deltas, drag to select an area on the heatmap.
  2. Confirm distribution switches to Selection/Background mode and clear (X) is visible.
  3. Click clear (X) or apply include/exclude from a distribution bar.
  4. Confirm:
    • selection coordinates are cleared
    • distribution returns to all spans mode
    • heatmap visual selection rectangle/popover is cleared

References

  • Linear: HDX-3693

Linear Issue: HDX-3693

Open in Web Open in Cursor 

Co-authored-by: Alex Fedotyev <alex-fedotyev@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2026

⚠️ No Changeset found

Latest commit: 7436e12

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment Mar 23, 2026 4:37pm

Request Review

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2026

Knip - Unused Code Analysis

0 change in total issues (240 on main → 240 on PR)

Category main PR Diff
Unused files 9 9 0
Unused dependencies 14 14 0
Unused devDependencies 20 20 0
Unlisted dependencies 14 14 0
Unresolved imports 2 2 0
Unlisted binaries 2 2 0
Unused exports 132 132 0
Unused exported types 41 41 0
Unused enum members 2 2 0
Duplicate exports 4 4 0
What is this?

Knip finds unused files, dependencies, and exports in your codebase.
This comment compares the PR branch against main to detect regressions.

Run yarn knip locally to see full details.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2026

E2E Test Results

All tests passed • 91 passed • 3 skipped • 979s

Status Count
✅ Passed 91
❌ Failed 0
⚠️ Flaky 2
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

cursoragent and others added 2 commits March 23, 2026 16:27
Co-authored-by: Alex Fedotyev <alex-fedotyev@users.noreply.github.com>
Co-authored-by: Alex Fedotyev <alex-fedotyev@users.noreply.github.com>
Co-authored-by: Alex Fedotyev <alex-fedotyev@users.noreply.github.com>
@alex-fedotyev
Copy link
Contributor Author

@elizabetdev - where do you think it is the best place for button "X" to clear the selection for comparison?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants