Conversation
🦋 Changeset detectedLatest commit: d7a8f18 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Knip - Unused Code Analysis⚪ No changes detected (1 issues on both main and PR) What is this?Knip finds unused files, dependencies, and exports in your codebase. Run |
E2E Test Results✅ All tests passed • 119 passed • 3 skipped • 1017s
Tests ran across 4 shards in parallel. |
pulpdrew
force-pushed
the
drew/dashboard-template-gallery
branch
from
3a450cd to
0e8fee1
Compare
pulpdrew
force-pushed
the
drew/dashboard-template-gallery
branch
from
0e8fee1 to
72fc51e
Compare
PR Reviewfeat: Add dashboard template gallery — Clean implementation overall, tests validate all templates against the Zod schema, and error handling for invalid template IDs is present.
✅ Everything else looks good — Zod schema validation on template load, proper |
pulpdrew
force-pushed
the
drew/dashboard-template-gallery
branch
from
72fc51e to
b4c0ded
Compare
| } | ||
|
|
||
| type FilterCheckboxProps = { | ||
| columnName: string; |
There was a problem hiding this comment.
Changes to this file are intended to fix flaky E2E tests caused by duplicate filter inputs (when the same label/value is present under multiple filter columns)
pulpdrew
force-pushed
the
drew/dashboard-template-gallery
branch
from
b4c0ded to
d45ea0d
Compare
| ).toHaveLength(0); | ||
| }); | ||
|
|
||
| it('does not validate valueExpression for metric sources', () => { |
There was a problem hiding this comment.
Fixes bug: Form submission error when submitting a metric query without first setting a value expression via a non-metric source
pulpdrew
requested review from
a team and
wrn14897
and removed request for
a team
| @@ -0,0 +1,367 @@ | |||
| { | |||
There was a problem hiding this comment.
Have we verified that these dashboard templates work as expected? One concern I have is the semantic conventions, since they tend to change over time.
Another thing is that we probably want to list the supported collector version range and I wonder if we want to introduce a 'Collector' tag for things like OTel or Vector, etc
There was a problem hiding this comment.
Have we verified that these dashboard templates work as expected?
@alex-fedotyev created them, and I have verified that they display the metrics produced by simple java/go/python/node/dotnet applications running locally with OTEL.
One concern I have is the semantic conventions, since they tend to change over time.
That's a good point. I can add the required semantic spec version in each description.
Since these are imported as saved dashboards (and are not hardcoded presets), if/when the semantic conventions change, users will likely have to update the impacted dashboard tiles themselves.
Another thing is that we probably want to list the supported collector version range
These metrics are collected by OTel language SDKs - would they depend on the collector version?
I wonder if we want to introduce a 'Collector' tag for things like OTel or Vector, etc
That's a good idea, I could tag these as "OTEL Runtime Metrics" instead of just "Runtime Metrics"
There was a problem hiding this comment.
I believe otel sdks follow semantic versioning (maybe that’s the version we should follow). Let's get this out and we can adjust templates time to time.
| @@ -0,0 +1,54 @@ | |||
| import { | |||
There was a problem hiding this comment.
I wonder if we could host a remote template gallery and open it up for contributions 🤔
2 participants
Summary
This PR adds a gallery of importable dashboard templates to the dashboards page. The existing Dashboard import functionality is modified to support importing dashboard templates which are included in the app source code bundle.
Screenshots or video
Screen.Recording.2026-03-30.at.8.52.12.AM.mov
How to test locally or on Vercel
This can be tested as shown above in the preview environment.
References