Skip to content

feat: use 1 minute window for searches#2019

Open
knudtty wants to merge 3 commits intomainfrom
aaron/default-search-smaller-window
Open

feat: use 1 minute window for searches#2019
knudtty wants to merge 3 commits intomainfrom
aaron/default-search-smaller-window

Conversation

@knudtty
Copy link
Copy Markdown
Contributor

@knudtty knudtty commented Mar 31, 2026

Summary

This PR changes searches to a 1 minute up front window, rather than a 6h. Also, the refresh time was moved from 4s back to 10s.

How to test locally or on Vercel

  1. Go to preview
  2. Inspect console and check a search query
  3. See search query is searching over 60 seconds

References

Closes HDX-3866

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 31, 2026

🦋 Changeset detected

Latest commit: 2fd250b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@knudtty knudtty requested review from a team and teeohhem and removed request for a team March 31, 2026 14:40
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment Mar 31, 2026 3:16pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

PR Review

  • ⚠️ windowDurationsSeconds recreated on every render (lines 460–463 in useOffsetPaginatedQuery.tsx) → wrap in useMemo with [enableSmallFirstWindow] dependency to avoid unnecessary array allocations and ensure stable reference passed to meta and getNextPageParam

  • ℹ️ DEFAULT_TIME_WINDOWS_SECONDS now starts with 15 * 60 (15m), changing the default windowing behavior for all callers (not just the search page). Ensure this regression is intentional — callers not passing enableSmallFirstWindow will now query 15m first instead of 6h.

✅ No critical bugs or security issues found. The feature logic is correct — enableSmallFirstWindow prepends a 1-min window cleanly without mutating the original array.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

Knip - Unused Code Analysis

⚪ No changes detected (0 issues on both main and PR)

What is this?

Knip finds unused files, dependencies, and exports in your codebase.
This comment compares the PR branch against main to detect regressions.

Run yarn knip locally to see full details.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

E2E Test Results

All tests passed • 117 passed • 3 skipped • 1009s

Status Count
✅ Passed 117
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant