SkipShieldingInputStream: do not assume buffer is never read#1125
Merged
ArneBab merged 1 commit intohyphanet:nextfrom Feb 15, 2026
Merged
SkipShieldingInputStream: do not assume buffer is never read#1125ArneBab merged 1 commit intohyphanet:nextfrom
ArneBab merged 1 commit intohyphanet:nextfrom
Conversation
The SkipShieldingInputStream used a shared buffer under the assumption that its contents are only written to, and are never read. However, some stream wrappers (hashing, cryptography) perform read-after-write on the buffers they are provided. When multiple threads skip(...) concurrently this can cause data from different unrelated streams to interfere with the other streams. Allocate a fresh buffer for every skip to prevent crosstalk between threads.
Contributor
Author
|
Alternatively we could change |
Contributor
|
Very nice catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SkipShieldingInputStream used a shared buffer under the assumption that its contents are only written to, and are never read. However, some stream wrappers (hashing, cryptography) perform read-after-write on the buffers they are provided.
When multiple threads skip(...) concurrently this can cause data from different unrelated streams to interfere with the other streams.
Allocate a fresh buffer for every skip to prevent crosstalk between threads.