Merged
Conversation
Collaborator
|
Can we add the check to the CI to ensure you got all newlines? |
Member
Author
|
Done. |
Bouncner
reviewed
Aug 10, 2025
| else | ||
| LIB_CFLAGS += -Wall -Werror | ||
| ifneq (,$(findstring clang,$(shell $(CXX) --version 2>/dev/null))) | ||
| LIB_CFLAGS += -Wnewline-eof |
Collaborator
There was a problem hiding this comment.
So the check is not part of Wall, yes?
Member
Author
There was a problem hiding this comment.
No.
If it was, the CI would have failed earlier.
Collaborator
There was a problem hiding this comment.
Can you add a comment that we explicitly add this check for Hyrise?
Collaborator
|
@dey4ss : anything to add from your side? |
Member
Author
|
lgtm? |
dey4ss
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Wnewline-eofis only available in Clang, so missing linebreaks at the end of files are not noticed here.But only because of the SQLParser is this warning manually disabled in Hyrise.
Let's change this.