Conversation
Some functions may require schema before the name. E.g.: MonetDB json.isarray
function: json.isarray('[1, 2, 3]'). PostgreSQL also allows it: "Schemas also
contain other kinds of named objects, including data types, functions, and
operators." (https://www.postgresql.org/docs/current/ddl-schemas.html). Let's
support it.
msiomkin
force-pushed
the
fn-schema
branch
4 times, most recently
from
d335d43 to
df8573d
Compare
dey4ss
reviewed
Oct 28, 2025
Member
dey4ss
left a comment
dey4ss
left a comment
There was a problem hiding this comment.
I just have one comment. Apart from that, it looks good to go.
| @@ -200,6 +201,8 @@ struct Expr { | |||
|
|
|||
| static Expr* makeFunctionRef(char* func_name, std::vector<Expr*>* exprList, bool distinct, WindowDescription* window); | |||
Member
There was a problem hiding this comment.
This method is not really required anymore, right? We could just use the new one and pass nullptr if there is no schema defined.
Contributor
Author
There was a problem hiding this comment.
Yes, we can if you insist on it. But I worry about backward compatibility. We don't need schema on functions very often. Most users use this method without schema. They'll have to fix their calls. More than that, they'll have to pass nullptr explicitly for a parameter they don't need 90% of time.
Member
There was a problem hiding this comment.
That's a valid point. Then, fine for me to go. Thanks for your contribution!
dey4ss
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some functions may require schema before the name. E.g.: MonetDB json.isarray function: json.isarray('[1, 2, 3]'). PostgreSQL also allows it: "Schemas also contain other kinds of named objects, including data types, functions, and operators." (https://www.postgresql.org/docs/current/ddl-schemas.html). Let's support it.