Support responsive rich resource types#293
Open
robd003 wants to merge 1 commit intoiamcal:masterfrom
Open
Conversation
A lot of widgets have a minimum width or height and if the consumer tries to scale down a rich content response for a mobile browser by using an assumed aspect ratio from the height/width it will most likely cut off part of the content.
Contributor
Author
|
I've had problems with my static height widget being resized due to consumers assuming they should use an aspect ratio when displaying our content. If we implement a min & max for width and height then responsive widgets can be displayed without having content cut off or tons of whitespace. |
Contributor
Author
|
@iamcal Any chance we could discuss this pull request? |
|
Why not set an aspect ratio instead of a min max width height? Which can be calculated like shown in this file https://github.com/twbs/bootstrap/blob/c28934cb1871d6b6bd6a866660493a1137de17c6/scss/helpers/_embed.scss |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of widgets have a minimum width or height and if the consumer
tries to scale down a rich content response for a mobile browser by
using an assumed aspect ratio from the height/width it will most likely
cut off part of the content.