Skip to content

IBX-11391: Handled deleted creator for trash item when listing items#1837

Open
barw4 wants to merge 1 commit intomainfrom
ibx-11259-trash-item-deleted-creator
Open

IBX-11391: Handled deleted creator for trash item when listing items#1837
barw4 wants to merge 1 commit intomainfrom
ibx-11259-trash-item-deleted-creator

Conversation

@barw4
Copy link
Contributor

@barw4 barw4 commented Feb 26, 2026

🎫 Issue IBX-11391

Description:

In 4.6 it was working correctly because we were simply doing:

        $ownerId = $trashItem->getContentInfo()->ownerId;

        if (false === (new UserExists($this->userService))->isSatisfiedBy($ownerId)) {
            return null;
        }

-> means no proxy was initialized for this resource.

In 5.0 we crashed on first line:

        $ownerId = $trashItem->getContentInfo()->getOwner()->getUserId();

        if (false === (new UserExists($this->userService))->isSatisfiedBy($ownerId)) {
            return null;
        }

because proxy was initialized causing 404 earlier.

For QA:

Documentation:

@barw4 barw4 changed the title IBX-11259: Handled deleted creator for trash item when listing items IBX-11391: Handled deleted creator for trash item when listing items Feb 26, 2026
@barw4 barw4 assigned barw4 and unassigned mikadamczyk, ciastektk and ViniTou Feb 26, 2026
@barw4 barw4 added Bug Something isn't working Ready for review labels Feb 26, 2026
@sonarqubecloud
Copy link

@barw4 barw4 requested a review from a team February 26, 2026 08:41
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a test coverage for this case?

@barw4
Copy link
Contributor Author

barw4 commented Feb 26, 2026

Should we have a test coverage for this case?

Honestly I don't see any benefit, it's trivial change and cannot break anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Ready for QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants