IBX-11259: Fixed download file by id by additionally handling queries version and language#718
Open
IBX-11259: Fixed download file by id by additionally handling queries version and language#718
Conversation
barw4
changed the title
|
ibexa-workflow-automation-1
bot
requested review from
Steveb-p,
ViniTou,
alongosz,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
konradoboza
approved these changes
Feb 26, 2026
ViniTou
approved these changes
Feb 26, 2026
Contributor
ViniTou
left a comment
ViniTou
left a comment
There was a problem hiding this comment.
Probably not worth it tho, but I would rather have version and language as additional parameters to those two - methodsdownloadBinaryFileAction/downloadBinaryFileByIdAction
Contributor
Author
I thought about it but that would require larger refactoring including admin-ui |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: