Provided cross-compatibility between doctrine/persistence v2 and v3#720
Provided cross-compatibility between doctrine/persistence v2 and v3#720
Conversation
wiewiurdp
changed the title
Enabled running Backend CI GHA on different versions of doctrine/persistence: v2 and v3
This reverts commit 314fb23.
alongosz
force-pushed
the
doctrine-persistence-require
branch
from
6a68215 to
c44face
Compare
alongosz
changed the title
| */ | ||
| public function clear($objectName = null): void | ||
| { | ||
| $this->getWrapped()->clear(); |
There was a problem hiding this comment.
We probably need to pass the 1st argument to the wrapped entity manager, regardless if it declares that it accepts an argument or not. Otherwise we will not be respecting the behavior of persistence v2 which allowed partial clear.
|
@alongosz to reduce the amount of check we can get rid of PHP 8.0 - 8.2 jobs from the matrix in favor of PHP 8.3 and 8.4. This can be done as a followup. |
* Provided cross-compatibility between doctrine/persistence v2 and v3 for SiteAccessAwareEntityManager
…age version Co-authored-by: OpenAI Codex <codex@openai.com>
Co-Authored-By: Paweł Niedzielski <Steveb-p@users.noreply.github.com>
alongosz
force-pushed
the
doctrine-persistence-require
branch
from
c44face to
cd46bed
Compare
Temporarily replaced PHP 8.0-8.1 with PHP 8.2, to be permanently replaced with PHP 8.3 and 8.4.
alongosz
force-pushed
the
doctrine-persistence-require
branch
from
cd46bed to
3136c28
Compare
|
@konradoboza The number of jobs has been reduced. I've removed doctrine matrix from unit & SQLite tests, keeping it only for MySQL and PostgreSQL, as essential. However for unit & SQLite I kept PHP 8.1 as a temporary measure to have at least one unit and integration running on PHP 8.x series. All of it to be replaced with PHP 8.3 & 8.4 as a follow-up right after merging this one. |
|
Sounds good, thank you @alongosz. |
alongosz
requested review from
ViniTou,
alongosz,
barw4,
ciastektk,
mikadamczyk and
tbialcz
7 participants
Note
Taken over by @alongosz
Related PRs:
Description:
Implementations of
\Doctrine\Persistence\ObjectManagerdiffer betweendoctrine/persistenceversions v2 and v3. Given the risk that putting new constraint on that package version might block existing projects from upgrading, we've aimed to provide aSiteAccessAwareEntityManager(implementing indirectlyObjectManager) class which is cross-compatible between both versions.There's no way to uniformly resolve PHPStan issues across both versions. We've introduced
doctrine/persistenceversion detection to load proper baseline.For QA:
Failing builds:
Commerce regression: ibexa/commerce#1709
Documentation:
No documentation required.