Skip to content

Update interface version for Midnight in HandyNotes_Achievements.toc#57

Draft
pidzi92 wants to merge 2 commits intoidiomatic:masterfrom
pidzi92:patch-1
Draft

Update interface version for Midnight in HandyNotes_Achievements.toc#57
pidzi92 wants to merge 2 commits intoidiomatic:masterfrom
pidzi92:patch-1

Conversation

@pidzi92
Copy link

@pidzi92 pidzi92 commented Feb 13, 2026

Midnight prepatch fix

@idiomatic
Copy link
Owner

Thanks for the contribution. Please look at 13305ad.

@idiomatic
Copy link
Owner

According to https://support.curseforge.com/support/solutions/articles/9000197321-curseforge-api, gameVersions is multivalue. However, our Makefile (simplistically) assumes a single-value game version.

If multivalue gameVersion is critical, the Makefile will have to be significantly reworked.

@idiomatic idiomatic marked this pull request as draft February 15, 2026 00:39
## Interface: 120000, 120001
## X-Min-Interface: 110200
## Interface: 120001
## X-Min-Interface: 120000
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am concerned that bumping this up to 120000 will break The War Within players until the Midnight expansion releases (2026-03-02).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, let's wait for release. Maybe there will be additional changes with the addons.

I am not sure how it works, I assumed TWW players still have to play with the new client, just the features are disabled. I may be wrong.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

if you find another mainstream addon that does it the right way, feel free and plagiarize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants