Update interface version for Midnight in HandyNotes_Achievements.toc#57
Update interface version for Midnight in HandyNotes_Achievements.toc#57pidzi92 wants to merge 2 commits intoidiomatic:masterfrom
Conversation
|
Thanks for the contribution. Please look at 13305ad. |
|
According to https://support.curseforge.com/support/solutions/articles/9000197321-curseforge-api, gameVersions is multivalue. However, our Makefile (simplistically) assumes a single-value game version. If multivalue gameVersion is critical, the Makefile will have to be significantly reworked. |
| ## Interface: 120000, 120001 | ||
| ## X-Min-Interface: 110200 | ||
| ## Interface: 120001 | ||
| ## X-Min-Interface: 120000 |
There was a problem hiding this comment.
I am concerned that bumping this up to 120000 will break The War Within players until the Midnight expansion releases (2026-03-02).
There was a problem hiding this comment.
In that case, let's wait for release. Maybe there will be additional changes with the addons.
I am not sure how it works, I assumed TWW players still have to play with the new client, just the features are disabled. I may be wrong.
There was a problem hiding this comment.
👍
if you find another mainstream addon that does it the right way, feel free and plagiarize.
Midnight prepatch fix