Skip to content

fix: remove conditional formatting for liaison bodies#10411

Closed
ghost wants to merge 1 commit intomainfrom
unknown repository
Closed

fix: remove conditional formatting for liaison bodies#10411
ghost wants to merge 1 commit intomainfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Feb 13, 2026

fixes #10129

@ghost ghost marked this pull request as ready for review February 13, 2026 15:32
@rjsparks
Copy link
Copy Markdown
Member

Simple code fix, but it's going to need a companion data fix, or at least an inspection to verify that the effect on the display of the existing statements is acceptable.

The entire liaison app is up for reimplementation (that effort is in a design phase that will accelerate after we deploy the rpc modernrization work). It would be best to check whether changes in that app are likely to just be replaced soon anyhow.

Rather than do the data display inspection now, lets hold it for the reimplementation.

@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 13, 2026

Simple code fix, but it's going to need a companion data fix, or at least an inspection to verify that the effect on the display of the existing statements is acceptable.

The entire liaison app is up for reimplementation (that effort is in a design phase that will accelerate after we deploy the rpc modernrization work). It would be best to check whether changes in that app are likely to just be replaced soon anyhow.

Rather than do the data display inspection now, lets hold it for the reimplementation.

okk, happy to try the markdown preview option. just simple fix as i was editing the template

@rjsparks
Copy link
Copy Markdown
Member

rjsparks commented Feb 13, 2026

Just in case - I think I'm still not shining the light on what I am trying to point out. This last line from the issue:

Either will require an effort to adjust existing bodies to display correctly after the change.

It's the existing data that will have to be inspected and possibly reconditioned when we make this change, not newly entered statements.

And again, this has really become input into the requirements for the re-implementation rather than requirements for point fixes.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.36%. Comparing base (4945809) to head (981196d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10411   +/-   ##
=======================================
  Coverage   88.36%   88.36%           
=======================================
  Files         325      325           
  Lines       43653    43653           
=======================================
  Hits        38573    38573           
  Misses       5080     5080           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ghost ghost closed this by deleting the head repository Feb 19, 2026
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 23, 2026
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Liaison statement bodies are conditionally reformatted and they shouldn't be.

1 participant