fix: remove conditional formatting for liaison bodies#10411
Conversation
|
Simple code fix, but it's going to need a companion data fix, or at least an inspection to verify that the effect on the display of the existing statements is acceptable. The entire liaison app is up for reimplementation (that effort is in a design phase that will accelerate after we deploy the rpc modernrization work). It would be best to check whether changes in that app are likely to just be replaced soon anyhow. Rather than do the data display inspection now, lets hold it for the reimplementation. |
okk, happy to try the markdown preview option. just simple fix as i was editing the template |
|
Just in case - I think I'm still not shining the light on what I am trying to point out. This last line from the issue:
It's the existing data that will have to be inspected and possibly reconditioned when we make this change, not newly entered statements. And again, this has really become input into the requirements for the re-implementation rather than requirements for point fixes. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10411 +/- ##
=======================================
Coverage 88.36% 88.36%
=======================================
Files 325 325
Lines 43653 43653
=======================================
Hits 38573 38573
Misses 5080 5080 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fixes #10129