feat: cancel interim meeting at materials page#10412
Conversation
|
Thanks for pushing this forward. This one is going to need additional tests. The code/template might need additional logic - the view needs to account for whether the meeting has already passed. Look to see if that's already available. Right now, it's gating on whether the materials cutoff has passed for chairs, and ignores whether the meeting is in the past if the user is part of the secretariat. On these views, the button to cancel should not be presented to anyone for a meeting that has already passed. |
have adjusted! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10412 +/- ##
==========================================
+ Coverage 88.36% 88.37% +0.01%
==========================================
Files 325 325
Lines 43653 43653
==========================================
+ Hits 38573 38579 +6
+ Misses 5080 5074 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| urlreverse('ietf.meeting.views.interim_request_cancel', | ||
| kwargs={'number': meeting.number}), | ||
| 'Cancel meeting points to wrong URL') | ||
|
|
There was a problem hiding this comment.
Please add tests confirming that the anonymous user, a user with no roles (see other tests for nobody), and a chair of a different group are not presented with the link.
| Meeting details | ||
| </a> | ||
| {% endif %} | ||
| {% with meeting_status.slug as status_slug %} |
|
|
||
| def test_interim_request_details_cancel(self): | ||
| """Test access to cancel meeting / session features""" | ||
| def test_interim_meeting_cancel(self): |
There was a problem hiding this comment.
(This note is just a comment not a request for change).
This move to call out the scope of the cancel is not incorrect, but it is somewhat subtle. It reflects what the current code assumes, but there is an outstanding bug (or at least misfeature) in the current code. We are slowly returning to having multi-day in-person interims. Right now the misfeature makes the groups that have them schedule them as multiple interim meetings. When we address that problem, the scope of this cancellation view will likely need to shift back to session (or we will need both cancel session and cancel meeting). Again, nothing to do about it right now other than be aware.
fixes #9887
