Skip to content

feat: cancel interim meeting at materials page#10412

Closed
ghost wants to merge 3 commits intomainfrom
unknown repository
Closed

feat: cancel interim meeting at materials page#10412
ghost wants to merge 3 commits intomainfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Feb 13, 2026

fixes #9887
Screenshot 2026-02-16 at 14 52 12

@rjsparks
Copy link
Copy Markdown
Member

Thanks for pushing this forward.

This one is going to need additional tests.

The code/template might need additional logic - the view needs to account for whether the meeting has already passed. Look to see if that's already available. Right now, it's gating on whether the materials cutoff has passed for chairs, and ignores whether the meeting is in the past if the user is part of the secretariat.

On these views, the button to cancel should not be presented to anyone for a meeting that has already passed.

@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 13, 2026

Thanks for pushing this forward.

This one is going to need additional tests.

The code/template might need additional logic - the view needs to account for whether the meeting has already passed. Look to see if that's already available. Right now, it's gating on whether the materials cutoff has passed for chairs, and ignores whether the meeting is in the past if the user is part of the secretariat.

On these views, the button to cancel should not be presented to anyone for a meeting that has already passed.

have adjusted!

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.37%. Comparing base (4945809) to head (0781747).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10412      +/-   ##
==========================================
+ Coverage   88.36%   88.37%   +0.01%     
==========================================
  Files         325      325              
  Lines       43653    43653              
==========================================
+ Hits        38573    38579       +6     
+ Misses       5080     5074       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

urlreverse('ietf.meeting.views.interim_request_cancel',
kwargs={'number': meeting.number}),
'Cancel meeting points to wrong URL')

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests confirming that the anonymous user, a user with no roles (see other tests for nobody), and a chair of a different group are not presented with the link.

Meeting details
</a>
{% endif %}
{% with meeting_status.slug as status_slug %}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This with is now not used.


def test_interim_request_details_cancel(self):
"""Test access to cancel meeting / session features"""
def test_interim_meeting_cancel(self):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This note is just a comment not a request for change).
This move to call out the scope of the cancel is not incorrect, but it is somewhat subtle. It reflects what the current code assumes, but there is an outstanding bug (or at least misfeature) in the current code. We are slowly returning to having multi-day in-person interims. Right now the misfeature makes the groups that have them schedule them as multiple interim meetings. When we address that problem, the scope of this cancellation view will likely need to shift back to session (or we will need both cancel session and cancel meeting). Again, nothing to do about it right now other than be aware.

@ghost ghost closed this by deleting the head repository Feb 19, 2026
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 23, 2026
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

canceling an interim is hard to figure out

1 participant