Skip to content

feat(animated gif): add Animated Gif widget#422

Open
randomboi404 wants to merge 11 commits intoignis-sh:mainfrom
randomboi404:patch-4
Open

feat(animated gif): add Animated Gif widget#422
randomboi404 wants to merge 11 commits intoignis-sh:mainfrom
randomboi404:patch-4

Conversation

@randomboi404
Copy link
Copy Markdown

@randomboi404 randomboi404 commented Sep 2, 2025

Added animated gif support.

output.mp4

linkfrg
linkfrg reviewed Sep 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@linkfrg linkfrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the doc page for this widget in docs/api/widgets

Comment thread ignis/widgets/animated_gif Outdated
Comment thread ignis/widgets/animated_gif Outdated
Comment thread ignis/widgets/animated_gif Outdated
Comment thread ignis/widgets/animated_gif Outdated
@randomboi404
Copy link
Copy Markdown
Author

randomboi404 commented Sep 4, 2025

Also, imma add docs too and fix those issues.

@randomboi404
Copy link
Copy Markdown
Author

randomboi404 commented Sep 4, 2025

Done! Also, I've set interpolation type as BILINEAR only.

linkfrg
linkfrg reviewed Sep 5, 2025
View reviewed changes
Comment thread ignis/widgets/animated_gif.py Outdated
Comment thread ignis/widgets/animated_gif.py Outdated
Comment thread ignis/widgets/animated_gif.py Outdated
@randomboi404
Copy link
Copy Markdown
Author

randomboi404 commented Sep 7, 2025

I think it's all done!!

@randomboi404
Copy link
Copy Markdown
Author

randomboi404 commented Sep 8, 2025

Fixed!

@randomboi404
Copy link
Copy Markdown
Author

randomboi404 commented Oct 4, 2025

Hello? @linkfrg

@linkfrg
Copy link
Copy Markdown
Member

linkfrg commented Oct 8, 2025

Sorry for not being here for a while, I have been a bit busy with school lately.
I did some general fixes in the latest two commits but there is one issue left. Looks like loop property as itself doesn't have any effect, only setting duration_ms to 0 actually loops the animation. We should either fix loop or remove it completely in favor of duration_ms=0

@randomboi404
Remove unused loop property from AnimatedGif
1224ecc 
Removed looping functionality from the animated GIF widget.
@randomboi404
Copy link
Copy Markdown
Author

randomboi404 commented Dec 30, 2025

Hey, @linkfrg

It's been a while. I was busy due to heavy irl work and hence I almost forgot about this. But yup, I am back and I made a commit which removes the loop property completely as duration_ms=0 handles it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linkfrg linkfrg linkfrg left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@randomboi404 @linkfrg