-
Notifications
You must be signed in to change notification settings - Fork 3
Remove method objects3d.get_objects_within_intensity
#123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #123 +/- ##
====================================
- Coverage 25% 25% -0%
====================================
Files 25 25
Lines 1711 1712 +1
====================================
Hits 421 421
- Misses 1290 1291 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, this method was introduced by @lguerard for a reason, as it does more than simply calling Objects3DPopulation.
Requests:
-
Discuss / approve with Laurent that it's okay to remove it. - Add it to the changelog as this is a breaking change.
- Explain what to use instead (and how).
|
Okay, obviously (and once again) I overlooked the related issue (#114) as it wasn't linked in the description - please avoid having issue numbers in new issue titles as my brain always gets tricked into thinking that number (in the title) is the number of this very issue / PR (not the referring one)... 🤦🏼 Instead, put the reference of the issue into the description and add it in the Development section on the right hand side. Thanks! 🤗 |
objects3d.get_objects_within_intensity
Remove method as it exists in the Image3D suite, refer: https://framagit.org/mcib3d/mcib3d-core/-/blob/master/src/main/java/mcib3d/geom/Objects3DPopulation.java?ref_type=heads#L1520