CROSSLINK-210 Add more search parameters

[JanisSaldabols]

No description provided.

[Copilot]

Pull request overview

Adds additional patron request search/filter capabilities by extending the patron_request schema and introducing a search view used by the list endpoint/CQL filtering. Also tightens supplier/requester lookup to include “side” and exposes the new needsAttention field through the API.

Changes:

• Add needs_attention column and introduce patron_request_search_view with derived search fields.
• Switch patron request listing to read from the new view and expand supported CQL fields.
• Update GetPatronRequestBySupplierSymbolAndRequesterReqId to include side, and propagate through service/tests; expose needsAttention in API responses.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
broker/test/patron_request/api/api-handler_test.go	Validates API returns default needsAttention=false; updates repo lookup call to include side.
broker/sqlc/pr_schema.sql	Adds needs_attention and defines patron_request_search_view used for searching.
broker/sqlc/pr_query.sql	Lists patron requests from the new view; adds needs_attention to create/update; adds side constraint to supplier+requesterReqId lookup.
broker/patron_request/service/message-handler.go	Updates supplier-side lookups to include SideLending.
broker/patron_request/service/action_test.go	Updates mock repo method signature to include side.
broker/patron_request/db/prrepo.go	Adapts list scanning/mapping to new list row shape; adds side parameter to lookup.
broker/patron_request/db/prcql.go	Adds additional CQL fields for filtering patron requests.
broker/patron_request/api/api-handler.go	Exposes needsAttention in API responses; ensures RequesterReqID is set on create.
broker/oapi/open-api.yaml	Documents new needsAttention field and CQL-filterable fields on GET /patron_requests.
broker/migrations/019_add_attention_field.up.sql	Migration adds needs_attention and creates the search view.
broker/migrations/019_add_attention_field.down.sql	Migration rollback drops the column and view.

---

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

---

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

---

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

---

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

---

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

---

You can also share your feedback on Copilot code review. Take the survey.

[jakub-id]

Auto-action failures still bypass the new needs_attention flag.

finalizeActionExecution() only calls setNeedsAttention() after RunAutoActionsOnStateEntry() returns successfully, but it returns early on auto-action error:

if stateChanged {
    err := a.RunAutoActionsOnStateEntry(ctx, updatedPr, &event.ID)
    if err != nil {
        return events.LogErrorAndReturnResult(ctx, "failed to execute auto action", err)
    }
}

if execResult.outcome == ActionOutcomeFailure && !updatedPr.NeedsAttention {
    a.setNeedsAttention(ctx, updatedPr)
}

That means a request can transition successfully, hit an auto action from the state model (NEW -> validate, supplier VALIDATED -> will-supply, etc.), fail there, and return an error without ever being marked for attention.

I think this is a behavioral gap relative to the new feature, since auto-triggered actions are still actions and their failures are exactly the kind of case an operator would need surfaced.

[jakub-id]

@JanisSaldabols can you drop go.work.sum from this PR?