Skip to content

Fix vertical label rotation on web#626

Open
ps-patryk wants to merge 1 commit intoindiespirit:masterfrom
ps-patryk:fix/366
Open

Fix vertical label rotation on web#626
ps-patryk wants to merge 1 commit intoindiespirit:masterfrom
ps-patryk:fix/366

Conversation

@ps-patryk
Copy link
Copy Markdown

Fixes #366

@KeitelDOG
Copy link
Copy Markdown

Hi, I'm using this package and I've seen this rotation problem in label, where the center of rotation is from Chat container instead of being inside of label container itself, so that it seems more like a Moon Revolution instead of auto-rotation that we need.

Can you tell more about your pull request codes, maybe they will merge it in new version.

@iexitdev
Copy link
Copy Markdown
Contributor

Maintainer triage note: the bug from #366 is real and this is a small targeted patch, but I would not merge this exact diff without a refresh.

After wrapping the label in G, the mapped root element no longer has the React key; the key remains on the child Text, which will produce key warnings. The web-only G positioning also needs verification against the current react-native-svg web behavior before merging.

Recommendation: worth salvaging/reworking, not a direct merge. If no one can verify and update it against current master, I would close it and track the issue with a fresh focused fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Label rotation does not do what is expected

4 participants