Skip to content

Windows Menu Support#24

Open
SeanBarker182 wants to merge 45 commits intomainfrom
feature/windows-menu
Open

Windows Menu Support#24
SeanBarker182 wants to merge 45 commits intomainfrom
feature/windows-menu

Conversation

@SeanBarker182
Copy link
Copy Markdown
Contributor

@SeanBarker182 SeanBarker182 commented Sep 25, 2025

Adds a menu to the Windows version of Reactotron.

Screen.Recording.2025-11-04.at.1.38.14.PM.mov

(Click to view screen recording.)

We went with a React Native menu system rather than native for flexibility; however, we may want to replace with a system menu in the future.

Here's a system menu as an example:

Windows system menu

For the future, we can possibly use GetSystemMenu and:

AppendMenuW(hMenu, MF_STRING, ID_MENU_ITEM, L"Menu Item");
InsertMenuW(hMenu, position, MF_BYPOSITION | MF_STRING, ID_MENU_ITEM, L"Item");
ModifyMenuW(hMenu, ID_MENU_ITEM, MF_BYCOMMAND | MF_STRING, ID_MENU_ITEM, L"New Text");
DeleteMenu(hMenu, ID_MENU_ITEM, MF_BYCOMMAND);

@SeanBarker182 SeanBarker182 marked this pull request as draft September 25, 2025 21:04
Comment thread app/components/Menu/MenuDropdownItem.tsx Fixed
@SeanBarker182 SeanBarker182 changed the title WIP: Windows Menu Support Windows Menu Support Nov 4, 2025
@SeanBarker182 SeanBarker182 marked this pull request as ready for review November 4, 2025 19:09
Copy link
Copy Markdown
Member

@jamonholmgren jamonholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to send these earlier this week ....

Comment thread app/components/Menu/MenuDropdown.tsx Outdated
Comment thread app/components/Menu/types.ts Outdated
Comment thread app/components/Menu/types.ts Outdated
Comment thread app/components/Menu/MenuDropdownItem.tsx Outdated
Comment thread app/components/Menu/MenuDropdownItem.tsx
Comment thread app/components/Menu/MenuDropdownItem.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants