fix: adds listener to ShardResult submission to catch errors #3831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awildturtok
approved these changes
Jan 19, 2026
|
|
||
| WriteFuture sendFailure = worker.send(failMessage); | ||
| sendFailure.addListener(failWriteFuture -> { | ||
| if (((WriteFuture)failWriteFuture).isWritten()) { |
Collaborator
Author
There was a problem hiding this comment.
Der Listener wird leider noch nicht ausgeführt wenn der OOM kommt 😢
thoniTUB
commented
Jan 20, 2026
Comment on lines
+62
to
66
| if (worker.getQueryExecutor().isCancelled(getExecutionId())) { | ||
| // Query is done so we no longer need the cancellation entry. | ||
| worker.getQueryExecutor().unsetQueryCancelled(getQueryId()); | ||
| worker.getQueryExecutor().unsetQueryCancelled(getExecutionId()); | ||
| return; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
@awildturtok Ich glaube das gehört hier eigentlich nicht mehr hin. Der Cancel-Status wird ganz zu anfang in der ExecuteQuery einmal aufgehoben
Collaborator
There was a problem hiding this comment.
ich meine, das war einfach nur um das set zu clearen, dass es nicht unnötig wächst.
awildturtok
approved these changes
Jan 20, 2026
backend/src/main/java/com/bakdata/conquery/models/error/ErrorMessages.java
Outdated
Show resolved
Hide resolved
Comment on lines
+62
to
66
| if (worker.getQueryExecutor().isCancelled(getExecutionId())) { | ||
| // Query is done so we no longer need the cancellation entry. | ||
| worker.getQueryExecutor().unsetQueryCancelled(getQueryId()); | ||
| worker.getQueryExecutor().unsetQueryCancelled(getExecutionId()); | ||
| return; | ||
| } |
Collaborator
There was a problem hiding this comment.
ich meine, das war einfach nur um das set zu clearen, dass es nicht unnötig wächst.
Co-authored-by: awildturtok <1553491+awildturtok@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.