Skip to content

Conversation

@initstring
Copy link
Owner

Motivation

  • Passkey/authenticator support was removed from the application but the Authenticator model and its relation remained in the Prisma schema and DB, causing confusion and potential upgrade issues.

Description

  • Removed the Authenticator model and the User.authenticators relation from prisma/schema.prisma to reflect the app's current auth model.
  • Added a migration SQL file prisma/migrations/20250207090000_remove_authenticator/migration.sql that drops the legacy Authenticator table from the database.
  • Kept the change focused to schema + migration only to preserve downstream Prisma shapes and avoid altering unrelated models.

Testing

  • Ran a code search with rg "Authenticator" -n to locate schema and migration uses (succeeded and confirmed references prior to removal).
  • Attempted npm run db:migrate -- --name remove-authenticator --create-only which failed in this environment due to DATABASE_URL not being set (expected in CI/local with proper env).
  • Attempted npx prisma migrate diff --from-migrations prisma/migrations --to-schema-datamodel prisma/schema.prisma --script which failed because a --shadow-database-url is required for diffs against a migrations directory (expected without a shadow DB).
  • A manual migration file was created to ensure database upgrades will drop the Authenticator table when applied in a properly configured environment.

Codex Task

@initstring
Copy link
Owner Author

@codex review.

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@initstring initstring merged commit 8569d37 into main Jan 17, 2026
5 checks passed
@initstring initstring deleted the codex/remove-authenticator-from-user-model branch January 17, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants