Skip to content

Conversation

@haraldmaida
Copy link
Member

Some tests for slices use a Vec as subject and give the owned Vec to the assert_that() function. These tests are actually duplicates to tests in the vec module.

Instead the tests in the slice module should call the assert_that() function giving a reference to the Vec.

Those tests have been fixed to take a reference to the Vec.

@haraldmaida haraldmaida self-assigned this Dec 26, 2025
@haraldmaida haraldmaida added the development An internal change related to development of this codebase label Dec 26, 2025
@codecov
Copy link

codecov bot commented Dec 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.95%. Comparing base (399c809) to head (2230882).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   93.95%   93.95%           
=======================================
  Files          32       32           
  Lines        4463     4463           
  Branches     4463     4463           
=======================================
  Hits         4193     4193           
  Misses        233      233           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haraldmaida haraldmaida merged commit 79974cd into main Dec 26, 2025
20 checks passed
@haraldmaida haraldmaida deleted the test/slice_tests_with_vec_should_take_reference_to_vec_subject branch December 26, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development An internal change related to development of this codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants