feat!: remove unused traits AssertBorrowedOptionValue and AssertBorrowedResultValue#89
Merged
Merged
Conversation
…rrowedResultValue` BREAKING-CHANGE: The traits `AssertBorrowedOptionValue` and `AssertBorrowedResultValue` have become obsolet, because implementing the traits `AssertOptionValue` and `AssertResultValue` for borrowed `Option` and borrowed `Result` is the better solution.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 87.95% 87.95%
=======================================
Files 42 42
Lines 6649 6649
Branches 6649 6649
=======================================
Hits 5848 5848
Misses 731 731
Partials 70 70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING-CHANGE: The traits
AssertBorrowedOptionValueandAssertBorrowedResultValuehave become obsolet, because implementing the traitsAssertOptionValueandAssertResultValuefor borrowedOptionand borrowedResultis the better solution.