Conversation
Soupstraw
force-pushed
the
jj/validator-trace
branch
3 times, most recently
from
329a2e6 to
9e2675c
Compare
Soupstraw
force-pushed
the
jj/validator-trace
branch
2 times, most recently
from
f64a179 to
9e65ce6
Compare
Soupstraw
force-pushed
the
jj/validator-trace
branch
from
e4712bc to
f8fe433
Compare
Soupstraw
requested review from
Copilot,
lehins,
neilmayhew and
teodanciu
and removed request for
Copilot
Soupstraw
force-pushed
the
jj/validator-trace
branch
from
97507bd to
33fe910
Compare
lehins
approved these changes
Feb 23, 2026
Member
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
LGTM. Thank you!
Could you please tidy up the git commit history, just a little bit. There is "WIP" an "minor fixes" maybe some more that you will spot.
Remove resolveIfRef Made changes to the executable
Add map/array squashing Fix test compilation errors Fix control validation Rename to prettyValidationTrace
Fix control prettyprinting
Soupstraw
force-pushed
the
jj/validator-trace
branch
2 times, most recently
from
14b809b to
4b274e7
Compare
Soupstraw
force-pushed
the
jj/validator-trace
branch
from
4b274e7 to
d6f1722
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds validation traces, which can be pretty-printed to provide lots of useful information about validation. For this I defined a
ValidationTracedatatype and then threaded it through the validator.Example 1
Example 2