Skip to content

[BUG]: fix github repository file id escaping#3415

Open
deiga wants to merge 2 commits into
integrations:mainfrom
F-Secure-web:fix-github_repository_file-id-escaping
Open

[BUG]: fix github repository file id escaping#3415
deiga wants to merge 2 commits into
integrations:mainfrom
F-Secure-web:fix-github_repository_file-id-escaping

Conversation

@deiga
Copy link
Copy Markdown
Collaborator

@deiga deiga commented May 10, 2026

Resolves #3335


Before the change?

After the change?

  • Terraform successfully operates on resources when filePath in github_repository_resource contains a colon

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

deiga added 2 commits May 10, 2026 21:21
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@github-actions github-actions Bot added the Type: Bug Something isn't working as documented label May 10, 2026
@deiga deiga marked this pull request as ready for review May 10, 2026 18:54
@deiga deiga changed the title fix github repository file id escaping [BUG]: fix github repository file id escaping May 10, 2026
@deiga deiga requested a review from stevehipwell May 10, 2026 18:55
@deiga deiga added the vNextPatch These issues and PRs should be included in the next patch release label May 10, 2026
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we tested this doesn't break existing IDs? It looks OK, but worth checking. Also should we add this to the next minor release milestone as we can always cherry pick it into a patch if required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working as documented vNextPatch These issues and PRs should be included in the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: github_repository_file rejects valid file paths containing ':' in v6.11.1

2 participants