feat: read timeout for github_ip_ranges data source#3421
Open
ffreitas-te wants to merge 1 commit into
Open
Conversation
Apply a default 5m read timeout and use the Terraform read context for the metadata API call so the timeout is enforced. Reintroduces the intent of the prior stale PR for configurable read timeouts. Refs: integrations#1961 integrations#1978
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
Author
|
Bumping for visibility: this addresses the long-running @KatKorotkikh — same class of pain as in #1961; feel free to weigh in if this matches what you hit in practice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the change?
github_ip_rangesdata source had notimeoutsblock, and the metadata request usedowner.StopContextinstead of the Terraform read context, so a read timeout would not reliably bound the HTTP call.After the change?
github_ip_ranges(overridable viatimeouts { read = "..." }in configuration).ReadContextctx, so Terraform's read deadline is honored.Pull request checklist
Schema migrations: N/A — this updates only the
github_ip_rangesdata source; no managed resource identity or Terraform state schema changes, so no migration code is required.Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Related to #1961
Follow-up to #1978 (previous change went stale; this re-applies the same intent on the current Terraform Plugin SDK v2 codebase.)
/cc @kimxogus @kfcampbell @KatKorotkikh