feat: Expose deploy_keys_enabled_for_repositories on github_organization_settings#3432
Open
JamBalaya56562 wants to merge 1 commit into
Open
feat: Expose deploy_keys_enabled_for_repositories on github_organization_settings#3432JamBalaya56562 wants to merge 1 commit into
JamBalaya56562 wants to merge 1 commit into
Conversation
…ion_settings Add the new `deploy_keys_enabled_for_repositories` boolean to the `github_organization_settings` resource and the `github_organization` data source. This mirrors the existing `members_can_fork_private_repositories` pattern (schema, read, buildOrganizationSettings, debug log, tests, docs, example). The field maps to `Organization.DeployKeysEnabledForRepositories`, added in go-github v86 via google/go-github#4188, which the project picked up in integrations#3413.
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the new
deploy_keys_enabled_for_repositoriesboolean to:github_organization_settingsresource (schema,buildOrganizationSettings, debug log, read)github_organizationdata source (schema, read)The diff follows the exact pattern of the adjacent
members_can_fork_private_repositoriesfield so the change stays minimal.Upstream wiring
The field maps to
Organization.DeployKeysEnabledForRepositories/GetDeployKeysEnabledForRepositories()in go-github, added ingoogle/go-github#4188 and
released in v86.0.0. This repository picked up v86 in #3413, so the field
is available without any further dependency change.
API reference
Update an organization
explicitly lists
deploy_keys_enabled_for_repositoriesas a PATCH-ableboolean parameter.
I verified end-to-end against a real org (
aletheia-works) while testingthe go-github PR — both GET (
/orgs/{org}) and PATCH responses includethis field.
Schema choice
Declared as
Optional + Computed(noDefault) so the provider does notsilently force a value when the user has not specified one. This matches
the conservative pattern of "read whatever the org currently has, only
write when explicitly set." If a
Default: falsestyle is preferred,happy to adjust.
Test plan
go build ./...go vet ./...go test -run TestNeverMatch ./github/...(compile-level check of thenew test assertions; acceptance tests require
TF_ACC=1+ tokens andwere not run locally)