Skip to content

✅ Use STATIC_REQUIRE instead of static_assert #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukevalenty merged 2 commits into from
May 24, 2025
Merged

✅ Use STATIC_REQUIRE instead of static_assert #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e51b460
:white_check_mark: Use `STATIC_REQUIRE` instead of `static_assert`
elbeno May 23, 2025
c8e86c6
:rotating_light: Apply black formatting to Python files that need it
elbeno May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions test/atomic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ TEMPLATE_TEST_CASE("atomic size and alignment is the same as the data",
"[atomic]", bool, char, signed char, unsigned char,
short int, unsigned short int, int, unsigned int, long int,
unsigned long int) {
static_assert(sizeof(stdx::atomic<TestType>) == sizeof(TestType));
static_assert(alignof(stdx::atomic<TestType>) == alignof(TestType));
STATIC_REQUIRE(sizeof(stdx::atomic<TestType>) == sizeof(TestType));
STATIC_REQUIRE(alignof(stdx::atomic<TestType>) == alignof(TestType));
}

TEMPLATE_TEST_CASE("atomic is default constructible when data is", "[atomic]",
bool, char, signed char, unsigned char, short int,
unsigned short int, int, unsigned int, long int,
unsigned long int) {
static_assert(std::is_default_constructible_v<stdx::atomic<TestType>>);
STATIC_REQUIRE(std::is_default_constructible_v<stdx::atomic<TestType>>);
}

namespace {
Expand All @@ -29,22 +29,22 @@ struct non_dc {

#if __cplusplus >= 202002L
TEST_CASE("atomic is not default constructible when data is not", "[atomic]") {
static_assert(not std::is_default_constructible_v<stdx::atomic<non_dc>>);
STATIC_REQUIRE(not std::is_default_constructible_v<stdx::atomic<non_dc>>);
}
#endif

TEST_CASE("atomic is not copyable or movable", "[atomic]") {
static_assert(not std::is_copy_constructible_v<stdx::atomic<int>>);
static_assert(not std::is_move_constructible_v<stdx::atomic<int>>);
static_assert(not std::is_copy_assignable_v<stdx::atomic<int>>);
static_assert(not std::is_move_assignable_v<stdx::atomic<int>>);
STATIC_REQUIRE(not std::is_copy_constructible_v<stdx::atomic<int>>);
STATIC_REQUIRE(not std::is_move_constructible_v<stdx::atomic<int>>);
STATIC_REQUIRE(not std::is_copy_assignable_v<stdx::atomic<int>>);
STATIC_REQUIRE(not std::is_move_assignable_v<stdx::atomic<int>>);
}

TEMPLATE_TEST_CASE("atomic supports value initialization", "[atomic]", bool,
char, signed char, unsigned char, short int,
unsigned short int, int, unsigned int, long int,
unsigned long int) {
static_assert(std::is_constructible_v<stdx::atomic<TestType>, TestType>);
STATIC_REQUIRE(std::is_constructible_v<stdx::atomic<TestType>, TestType>);
[[maybe_unused]] auto x = stdx::atomic<TestType>{TestType{}};
}

Expand Down
52 changes: 26 additions & 26 deletions test/atomic_bitset.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,34 +9,34 @@

TEST_CASE("atomic_bitset with explicit storage element type",
"[atomic_bitset]") {
static_assert(sizeof(stdx::atomic_bitset<1, std::uint8_t>) ==
sizeof(std::uint8_t));
static_assert(sizeof(stdx::atomic_bitset<8, std::uint8_t>) ==
sizeof(std::uint8_t));
static_assert(sizeof(stdx::atomic_bitset<1, std::uint16_t>) ==
sizeof(std::uint16_t));
static_assert(sizeof(stdx::atomic_bitset<16, std::uint16_t>) ==
sizeof(std::uint16_t));
static_assert(sizeof(stdx::atomic_bitset<1, std::uint32_t>) ==
sizeof(std::uint32_t));
static_assert(sizeof(stdx::atomic_bitset<32, std::uint32_t>) ==
sizeof(std::uint32_t));
static_assert(sizeof(stdx::atomic_bitset<1, std::uint64_t>) ==
sizeof(std::uint64_t));
static_assert(sizeof(stdx::atomic_bitset<64, std::uint64_t>) ==
sizeof(std::uint64_t));
STATIC_REQUIRE(sizeof(stdx::atomic_bitset<1, std::uint8_t>) ==
sizeof(std::uint8_t));
STATIC_REQUIRE(sizeof(stdx::atomic_bitset<8, std::uint8_t>) ==
sizeof(std::uint8_t));
STATIC_REQUIRE(sizeof(stdx::atomic_bitset<1, std::uint16_t>) ==
sizeof(std::uint16_t));
STATIC_REQUIRE(sizeof(stdx::atomic_bitset<16, std::uint16_t>) ==
sizeof(std::uint16_t));
STATIC_REQUIRE(sizeof(stdx::atomic_bitset<1, std::uint32_t>) ==
sizeof(std::uint32_t));
STATIC_REQUIRE(sizeof(stdx::atomic_bitset<32, std::uint32_t>) ==
sizeof(std::uint32_t));
STATIC_REQUIRE(sizeof(stdx::atomic_bitset<1, std::uint64_t>) ==
sizeof(std::uint64_t));
STATIC_REQUIRE(sizeof(stdx::atomic_bitset<64, std::uint64_t>) ==
sizeof(std::uint64_t));
}

TEST_CASE("atomic_bitset with implicit storage element type",
"[atomic_bitset]") {
static_assert(sizeof(stdx::atomic_bitset<1>) == sizeof(std::uint8_t));
static_assert(sizeof(stdx::atomic_bitset<8>) == sizeof(std::uint8_t));
static_assert(sizeof(stdx::atomic_bitset<9>) == sizeof(std::uint16_t));
static_assert(sizeof(stdx::atomic_bitset<16>) == sizeof(std::uint16_t));
static_assert(sizeof(stdx::atomic_bitset<17>) == sizeof(std::uint32_t));
static_assert(sizeof(stdx::atomic_bitset<32>) == sizeof(std::uint32_t));
static_assert(sizeof(stdx::atomic_bitset<33>) == sizeof(std::uint64_t));
static_assert(sizeof(stdx::atomic_bitset<64>) == sizeof(std::uint64_t));
STATIC_REQUIRE(sizeof(stdx::atomic_bitset<1>) == sizeof(std::uint8_t));
STATIC_REQUIRE(sizeof(stdx::atomic_bitset<8>) == sizeof(std::uint8_t));
STATIC_REQUIRE(sizeof(stdx::atomic_bitset<9>) == sizeof(std::uint16_t));
STATIC_REQUIRE(sizeof(stdx::atomic_bitset<16>) == sizeof(std::uint16_t));
STATIC_REQUIRE(sizeof(stdx::atomic_bitset<17>) == sizeof(std::uint32_t));
STATIC_REQUIRE(sizeof(stdx::atomic_bitset<32>) == sizeof(std::uint32_t));
STATIC_REQUIRE(sizeof(stdx::atomic_bitset<33>) == sizeof(std::uint64_t));
STATIC_REQUIRE(sizeof(stdx::atomic_bitset<64>) == sizeof(std::uint64_t));
}

TEMPLATE_TEST_CASE("index operation", "[atomic_bitset]", std::uint8_t,
Expand Down Expand Up @@ -162,7 +162,7 @@ TEST_CASE("to_natural returns smallest_uint", "[atomic_bitset]") {
auto bs = stdx::atomic_bitset<4>{stdx::all_bits};
auto value = bs.to_natural();
CHECK(value == 0b1111);
static_assert(std::is_same_v<decltype(value), std::uint8_t>);
STATIC_REQUIRE(std::is_same_v<decltype(value), std::uint8_t>);
}

TEMPLATE_TEST_CASE("construct with a string_view", "[atomic_bitset]",
Expand Down Expand Up @@ -301,7 +301,7 @@ enum struct Bits : std::uint8_t { ZERO, ONE, TWO, THREE, MAX };

TEST_CASE("use atomic_bitset with enum struct (construct)", "[atomic_bitset]") {
constexpr auto bs = stdx::atomic_bitset<Bits::MAX>{};
static_assert(bs.size() == stdx::to_underlying(Bits::MAX));
STATIC_REQUIRE(bs.size() == stdx::to_underlying(Bits::MAX));
}

TEST_CASE("use atomic_bitset with enum struct (to)", "[atomic_bitset]") {
Expand Down
6 changes: 3 additions & 3 deletions test/atomic_bitset_override.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
TEST_CASE("atomic_bitset works with overridden type",
"[atomic_bitset_override]") {
auto bs = stdx::atomic_bitset<4>{};
static_assert(sizeof(decltype(bs)) == sizeof(std::uint32_t));
static_assert(alignof(decltype(bs)) == alignof(std::uint32_t));
STATIC_REQUIRE(sizeof(decltype(bs)) == sizeof(std::uint32_t));
STATIC_REQUIRE(alignof(decltype(bs)) == alignof(std::uint32_t));
}

TEST_CASE("to_natural returns smallest_uint", "[atomic_bitset_override]") {
auto bs = stdx::atomic_bitset<4>{stdx::all_bits};
auto value = bs.to_natural();
CHECK(value == 0b1111);
static_assert(std::is_same_v<decltype(value), std::uint8_t>);
STATIC_REQUIRE(std::is_same_v<decltype(value), std::uint8_t>);
}
12 changes: 6 additions & 6 deletions test/atomic_override.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@
TEST_CASE("atomic with overridden type is correctly sized/aligned",
"[atomic_override]") {
auto bs = stdx::atomic<bool>{};
static_assert(sizeof(decltype(bs)) == sizeof(std::uint32_t));
static_assert(alignof(decltype(bs)) == alignof(std::uint32_t));
STATIC_REQUIRE(sizeof(decltype(bs)) == sizeof(std::uint32_t));
STATIC_REQUIRE(alignof(decltype(bs)) == alignof(std::uint32_t));
}

TEST_CASE("atomic with overridden type presents interface of original type",
"[atomic_override]") {
auto bs = stdx::atomic<bool>{};
static_assert(std::is_same_v<decltype(bs.load()), bool>);
STATIC_REQUIRE(std::is_same_v<decltype(bs.load()), bool>);
}

TEST_CASE("atomic works with overridden type", "[atomic_override]") {
Expand All @@ -28,7 +28,7 @@ TEST_CASE("atomic works with overridden type", "[atomic_override]") {
TEST_CASE("atomic config works with partial specialization",
"[atomic_override]") {
using elem_t = ::atomic::atomic_type_t<int *>;
static_assert(std::is_same_v<elem_t, uintptr_t>);
STATIC_REQUIRE(std::is_same_v<elem_t, uintptr_t>);
}

#if __cplusplus >= 202002L
Expand All @@ -38,7 +38,7 @@ enum E : std::uint8_t {};

TEST_CASE("atomic config works with enum", "[atomic_override]") {
auto bs = stdx::atomic<E>{};
static_assert(sizeof(decltype(bs)) == sizeof(std::uint32_t));
static_assert(alignof(decltype(bs)) == alignof(std::uint32_t));
STATIC_REQUIRE(sizeof(decltype(bs)) == sizeof(std::uint32_t));
STATIC_REQUIRE(alignof(decltype(bs)) == alignof(std::uint32_t));
}
#endif
4 changes: 2 additions & 2 deletions test/bind.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

TEST_CASE("bind_front basic operation", "[bind]") {
constexpr auto f = stdx::bind_front([](int x, int y) { return x - y; }, 42);
static_assert(f(17) == 25);
STATIC_REQUIRE(f(17) == 25);
}

TEST_CASE("bind_front with rvalue", "[bind]") {
Expand All @@ -35,7 +35,7 @@ TEST_CASE("bind_front with lambda template argument", "[bind]") {

TEST_CASE("bind_back basic operation", "[bind]") {
constexpr auto f = stdx::bind_back([](int x, int y) { return x - y; }, 17);
static_assert(f(42) == 25);
STATIC_REQUIRE(f(42) == 25);
}

TEST_CASE("bind_back with rvalue", "[bind]") {
Expand Down
Loading