Skip to content

🐛 Make as_[un]signed constexpr #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elbeno merged 1 commit into from
May 30, 2025
Merged

🐛 Make as_[un]signed constexpr #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/stdx/utility.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,14 +97,14 @@ template <typename T, typename U>
using forward_like_t = decltype(forward_like<T>(std::declval<U>()));

template <typename T, std::enable_if_t<std::is_integral_v<T>, int> = 0>
[[nodiscard]] auto as_unsigned(T t) {
[[nodiscard]] constexpr auto as_unsigned(T t) {
static_assert(not std::is_same_v<T, bool>,
"as_unsigned is not applicable to bool");
return static_cast<std::make_unsigned_t<T>>(t);
}

template <typename T, std::enable_if_t<std::is_integral_v<T>, int> = 0>
[[nodiscard]] auto as_signed(T t) {
[[nodiscard]] constexpr auto as_signed(T t) {
static_assert(not std::is_same_v<T, bool>,
"as_signed is not applicable to bool");
return static_cast<std::make_signed_t<T>>(t);
Expand Down
4 changes: 4 additions & 0 deletions test/utility.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,14 @@ TEST_CASE("as_unsigned (changed)", "[utility]") {
std::uint32_t>);
STATIC_REQUIRE(std::is_same_v<decltype(stdx::as_unsigned(std::int64_t{})),
std::uint64_t>);
STATIC_REQUIRE(stdx::as_unsigned(std::int8_t{17}) == 17);
}

TEMPLATE_TEST_CASE("as_unsigned (unchanged)", "[utility]", std::uint8_t,
std::uint16_t, std::uint32_t, std::uint64_t) {
STATIC_REQUIRE(
std::is_same_v<decltype(stdx::as_unsigned(TestType{})), TestType>);
STATIC_REQUIRE(stdx::as_unsigned(TestType{17}) == 17);
}

TEST_CASE("as_signed (changed)", "[utility]") {
Expand All @@ -49,12 +51,14 @@ TEST_CASE("as_signed (changed)", "[utility]") {
std::int32_t>);
STATIC_REQUIRE(std::is_same_v<decltype(stdx::as_signed(std::uint64_t{})),
std::int64_t>);
STATIC_REQUIRE(stdx::as_signed(std::uint8_t{17}) == 17);
}

TEMPLATE_TEST_CASE("as_signed (unchanged)", "[utility]", std::int8_t,
std::int16_t, std::int32_t, std::int64_t) {
STATIC_REQUIRE(
std::is_same_v<decltype(stdx::as_signed(TestType{})), TestType>);
STATIC_REQUIRE(stdx::as_signed(TestType{17}) == 17);
}

TEMPLATE_TEST_CASE("sized<T> in (uint8_t zero/one/two case)", "[utility]",
Expand Down