Merged
Conversation
Problem: - The `CX_WRAP` and `CX_VALUE` macros jump through hoops to retrieve the type (when a type is passed in). It's simpler to use `__typeof__`. Solution: - Replace `type_of` and `typer` constructs with `__typeof__`.
Problem: - `CX_WRAP` on types returns a callable that returns a `type_identity`. In fact, `type_identity` is an empty struct, so it's constexpr-usable. Solution: - Return a `type_identity<T>` from `CX_WRAP(T)`. Note: - `STDX_CT_FORMAT` tests are unaltered and still format type names at compile time.
lukevalenty
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
CX_WRAPandCX_VALUEmacros jump through hoops to retrieve the type (when a type is passed in). It's simpler to use__typeof__.CX_WRAPon types returns a callable that returns atype_identity. In fact,type_identityis an empty struct, so it's constexpr-usable.Solution:
type_ofandtyperconstructs with__typeof__.type_identity<T>fromCX_WRAP(T).Note:
STDX_CT_FORMATtests are unaltered and still format type names at compile time.