🐛 Fix fallback implementation of bit_ceil#307
Merged
elbeno merged 1 commit intointel:mainfrom Jan 5, 2026
Merged
Conversation
elbeno
force-pushed
the
fix-fallback-bit-ceil
branch
from
5a7934a to
48a3137
Compare
Problem: - The fallback implementation of `bit_ceil` is implemented incorrectly. In particular it returns the wrong values for exact powers of 2. Solution: - Fix the calculation: subtracting 1 before calculating the bit width is appropriate. Notes: - Thanks to Walter Brown for pointing out this issue in private correspondence. - Undoubtedly, this was missed because of issue intel#117.
elbeno
force-pushed
the
fix-fallback-bit-ceil
branch
from
48a3137 to
feef4dd
Compare
mjcaisse-intel
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
bit_ceilis implemented incorrectly. In particular it returns the wrong values for exact powers of 2.Solution:
Notes: