✨ Include span information in format_result#316
Merged
bdeane-intel merged 2 commits intointel:mainfrom Jan 21, 2026
Merged
Conversation
Problem: - When outputting log information to JSON, some information is lost from the `format_result`: namely the types and resulting spans (string locations) of the values that were compile-time formatted. Solution: - Adjust `format_result` to include information about all values and their locations in the format string.
48479de to
fe530eb
Compare
Contributor
|
Is the intention for locations of both runtime and compile-time values to be listed in the spans? For example, spans for compile-time values would show the start and end of the actual compile-time value string representation in the formatted string...and spans for runtime-values would show the start and end of the format specifier "{...}". ETA: I am indifferent to the result, just curious to know which direction this is going in. |
Contributor
|
What happens when format results are formatted into another format result? I would expect to see multiple spans. For example: I would expect a span for each substituted compile-time value at each level. |
Problem: - Formatting of move-only types does not work. Solution: - Move the values through the formatting machinery appropriately.
Contributor
Author
|
lukevalenty
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
format_result: namely the types and resulting spans (string locations) ofthe values that were compile-time formatted.
Solution:
format_resultto include information about all values and theirlocations in the format string.