Merged
Conversation
Problems: - Handling of field and register names is a bit more complex than needed. - `read()` instantiates `mp_list` unnecessarily. - Using `same_as` in tests gives a worse error message than using `is_same_v` when it fails. Solution: - Simply `name` handling to be more value-based. - Don't change `tuple` to `mp_list` and back again. - Replace `same_as` with `is_same_v` in tests. Note: - The `same_as` change is surprising, but when it fails, `is_same_v` prints the actual types: `same_as` just says it failed.
mjcaisse-intel
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems:
read()instantiatesmp_listunnecessarily.same_asin tests gives a worse error message than usingis_same_vwhen it fails.Solution:
namehandling to be more value-based.tupletomp_listand back again.same_aswithis_same_vin tests.Note:
same_aschange is surprising, but when it fails,is_same_vprints the actual types:same_asjust says it failed. To be fair, the error does get out eventually. But both clang and GCC do better and terser with the type trait: https://godbolt.org/z/Koa4sczee