[UR][HIP] Make ur_context_handle_t_ destructor non-throwing #20887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UR_CHECK_ERROR may throw or abort, which is unsafe to use from a destructor. If an exception escapes during stack unwinding, std::terminate would be called. Replace UR_CHECK_ERROR in ur_context_handle_t_ destructor with a non-throwing, best-effort cleanup. In debug builds, failures are reported via assert/log, while release builds avoid throwing from the destructor. This fixes Coverity CID 519631, issue: [Coverity][UR] Potentially throwing function is called from a destructor
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Make the CUDA context destructor non-throwing by catching exceptions and using best-effort cleanup with logging and debug asserts. Related to Coverity CID 519631.
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bratpiorka
approved these changes
Dec 16, 2025
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
urAdapterRelease() always returns UR_RESULT_SUCCESS, making the error-checking code unreachable dead code. Exceptions from the call are already handled by the catch-all block.
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kswiecicki
reviewed
Dec 17, 2025
| if (MemoryProviderHost) { | ||
| umfMemoryProviderDestroy(MemoryProviderHost); | ||
| } | ||
| urAdapterRelease(ur::cuda::adapter); |
Contributor
There was a problem hiding this comment.
I don't think any of those functions (umfPoolDestroy/umfMemoryProviderDestroy/urAdapterRelease) can throw a reasonable exception. Since urAdapterRelease isn't wrapped with UR_CHECK_ERROR the try catch block seems redundant.
Contributor
|
@intel/llvm-gatekeepers please consider merging |
1 similar comment
Contributor
|
@intel/llvm-gatekeepers please consider merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UR_CHECK_ERROR may throw or abort, which is unsafe to use from a destructor. If an exception escapes during stack unwinding, std::terminate would be called.
Replace UR_CHECK_ERROR in ur_context_handle_t_ destructor with a non-throwing, best-effort cleanup. In debug builds, failures are reported via assert/log, while release builds avoid throwing from the destructor.
fixes: #20811