[SYCL][UR] move UR headers to dedicated unified-runtime include directory by ldorau · Pull Request #21399 · intel/llvm

ldorau · 2026-02-27T22:30:07Z

This aligns how headers are installed by other components.
While UR was never meant to be used directly,
this change may break existing software that includes <ur_api.h>.

Ref: #21421

ldorau · 2026-02-27T22:50:45Z

Please review @pbalcer

ldorau · 2026-03-02T08:06:58Z

Please review @intel/bindless-images-reviewers @intel/dpcpp-nativecpu-reviewers @intel/llvm-reviewers-cuda @intel/llvm-reviewers-runtime @intel/sycl-graphs-reviewers @intel/unified-runtime-reviewers @intel/unified-runtime-reviewers-level-zero @intel/unified-runtime-reviewers-opencl

sycl/CMakeLists.txt

mmichel11 · 2026-03-02T14:20:05Z

The nightly benchmarks from intel/compute-benchmarks rely on including ur_api.h for direct UR benchmarking. Could we couple this PR with a change to the compute benchmarks and a benchmark commit id update, so we don't break the nightly run?

Probably need to ensure compatibility with older versions with a __has_include check.

pbalcer · 2026-03-02T14:23:33Z

The nightly benchmarks from intel/compute-benchmarks rely on including ur_api.h for direct UR benchmarking. Could we couple this PR with a change to the compute benchmarks and a benchmark commit id update, so we don't break the nightly run?

Probably need to ensure compatibility with older versions with a __has_include check.

That's a good shout, thanks! Yes, we should do that.

First look for <ur/ur_api.h>, then <ur_api.h> for compatibility with older versions. Ref: intel/llvm#21399 Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>

ldorau · 2026-03-02T16:01:48Z

The nightly benchmarks from intel/compute-benchmarks rely on including ur_api.h for direct UR benchmarking. Could we couple this PR with a change to the compute benchmarks and a benchmark commit id update, so we don't break the nightly run?
Probably need to ensure compatibility with older versions with a __has_include check.

That's a good shout, thanks! Yes, we should do that.

@mmichel11 Done: intel/compute-benchmarks#42

First look for <ur/ur_api.h>, then <ur_api.h> for compatibility with older versions. Ref: intel/llvm#21399 Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>

ldorau · 2026-03-03T07:19:08Z

The UR CUDA precommit conformance test exp_usm_context_memcpy/urUSMContextMemcpyExp fails because of #19688

ldorau · 2026-03-03T07:26:55Z

Please review @intel/bindless-images-reviewers @intel/dpcpp-nativecpu-reviewers @intel/llvm-reviewers-cuda @intel/llvm-reviewers-runtime @intel/sycl-graphs-reviewers @intel/unified-runtime-reviewers @intel/unified-runtime-reviewers-level-zero @intel/unified-runtime-reviewers-opencl

lukaszstolarczuk · 2026-03-03T12:19:55Z

The nightly benchmarks from intel/compute-benchmarks rely on including ur_api.h for direct UR benchmarking. Could we couple this PR with a change to the compute benchmarks and a benchmark commit id update, so we don't break the nightly run?
Probably need to ensure compatibility with older versions with a __has_include check.

That's a good shout, thanks! Yes, we should do that.

@mmichel11 Done: intel/compute-benchmarks#42

I will update the benchmarks' scripts in #21421 once your commit is available.

First look for <ur/ur_api.h>, then <ur_api.h> for compatibility with older versions. Ref: intel/llvm#21399 Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>

ldorau · 2026-03-03T12:33:49Z

The nightly benchmarks from intel/compute-benchmarks rely on including ur_api.h for direct UR benchmarking. Could we couple this PR with a change to the compute benchmarks and a benchmark commit id update, so we don't break the nightly run?
Probably need to ensure compatibility with older versions with a __has_include check.

That's a good shout, thanks! Yes, we should do that.

@mmichel11 Done: intel/compute-benchmarks#42

I will update the benchmarks' scripts in #21421 once your commit is available.

There already is: intel/compute-benchmarks@48504d2

ldorau · 2026-03-03T15:19:42Z

The nightly benchmarks from intel/compute-benchmarks rely on including ur_api.h for direct UR benchmarking. Could we couple this PR with a change to the compute benchmarks and a benchmark commit id update, so we don't break the nightly run?
Probably need to ensure compatibility with older versions with a __has_include check.

That's a good shout, thanks! Yes, we should do that.

@mmichel11 Done: intel/compute-benchmarks#42

Regarding "a benchmark commit id update":
@mmichel11 Done: #21421

ldorau · 2026-03-04T09:07:38Z

Please review @intel/bindless-images-reviewers @intel/dpcpp-nativecpu-reviewers @intel/llvm-reviewers-cuda @intel/llvm-reviewers-runtime @intel/sycl-graphs-reviewers @intel/unified-runtime-reviewers @intel/unified-runtime-reviewers-level-zero @intel/unified-runtime-reviewers-opencl

bratpiorka · 2026-03-04T10:01:11Z

CUDA/HIP adapters LGTM

adamfidel

Graph changes LGTM.

ldorau · 2026-03-04T17:06:46Z

Rebased because of conflicts.

ldorau · 2026-03-04T17:07:56Z

Please review @intel/bindless-images-reviewers, @intel/llvm-reviewers-runtime and @intel/unified-runtime-reviewers-level-zero

ldorau · 2026-03-05T13:51:37Z

Renamed include/ur to include/unified-runtime.

ldorau · 2026-03-05T13:51:52Z

Please review @intel/bindless-images-reviewers, @intel/llvm-reviewers-runtime and @intel/unified-runtime-reviewers-level-zero

…tory This aligns how headers are installed by other components. While UR was never meant to be used directly, this change may break existing software that includes <ur_api.h>. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>

ldorau · 2026-03-06T08:06:52Z

Please review @intel/bindless-images-reviewers, @intel/llvm-reviewers-runtime and @intel/unified-runtime-reviewers-level-zero

First look for <unified-runtime/ur_api.h>, then <ur_api.h> for compatibility with older versions. The decision was changed after #2143 and the Unified Runtime include directory was changed to `include/unified-runtime/`. Ref: intel/llvm#21399 Ref: #2143 Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>

pbalcer · 2026-03-09T15:33:41Z

@intel/bindless-images-reviewers @intel/llvm-reviewers-runtime please review

to work properly with new UR headers location. Ref. intel#21399

github-actions · 2026-03-09T19:18:01Z

@intel/llvm-gatekeepers please consider merging

lukaszstolarczuk · 2026-03-09T19:19:17Z

This PR should be best merged along with #21468 for nightly benchmarks to work properly :)

to work properly with new UR headers location. Ref. #21399 Ref. intel/compute-benchmarks@2be1a1e

ldorau requested review from a team as code owners February 27, 2026 22:30

ldorau requested review from adamfidel, bratpiorka, pbalcer and sergey-semenov February 27, 2026 22:30

KFilipek approved these changes Mar 2, 2026

View reviewed changes

pbalcer reviewed Mar 2, 2026

View reviewed changes

sycl/CMakeLists.txt Outdated Show resolved Hide resolved

ldorau force-pushed the move-ur-headers-to-dir branch from e6fb3a0 to 8ddbcdb Compare March 2, 2026 13:47

ldorau mentioned this pull request Mar 2, 2026

The ur_api.h header has been moved to ur subdirectory intel/compute-benchmarks#42

Closed

ldorau requested a review from pbalcer March 2, 2026 16:02

bratpiorka approved these changes Mar 4, 2026

View reviewed changes

adamfidel approved these changes Mar 4, 2026

View reviewed changes

ldorau force-pushed the move-ur-headers-to-dir branch from 8ddbcdb to b3e091f Compare March 4, 2026 17:06

ldorau changed the title ~~[SYCL][UR] move UR headers to dedicated ur include directory~~ [SYCL][UR] move UR headers to dedicated unified-runtime include directory Mar 5, 2026

ldorau force-pushed the move-ur-headers-to-dir branch from b3e091f to 81973e8 Compare March 5, 2026 13:50

ldorau force-pushed the move-ur-headers-to-dir branch from 81973e8 to 08a647c Compare March 5, 2026 14:32

kswiecicki approved these changes Mar 9, 2026

View reviewed changes

pbalcer approved these changes Mar 9, 2026

View reviewed changes

0x12CC approved these changes Mar 9, 2026

View reviewed changes

sergey-semenov approved these changes Mar 9, 2026

View reviewed changes

lukaszstolarczuk added a commit to lukaszstolarczuk/llvm that referenced this pull request Mar 9, 2026

[Bench] Update Compute Benchmarks version

a2abed7

to work properly with new UR headers location. Ref. intel#21399

lukaszstolarczuk mentioned this pull request Mar 9, 2026

[Bench] Update Compute Benchmarks version #21468

Merged

kswiecicki merged commit 3396b52 into intel:sycl Mar 10, 2026
75 of 81 checks passed

kswiecicki pushed a commit that referenced this pull request Mar 10, 2026

[Bench] Update Compute Benchmarks version (#21468)

e276d4a

to work properly with new UR headers location. Ref. #21399 Ref. intel/compute-benchmarks@2be1a1e

Conversation

ldorau commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldorau commented Feb 27, 2026

Uh oh!

ldorau commented Mar 2, 2026

Uh oh!

Uh oh!

mmichel11 commented Mar 2, 2026

Uh oh!

pbalcer commented Mar 2, 2026

Uh oh!

ldorau commented Mar 2, 2026

Uh oh!

ldorau commented Mar 3, 2026

Uh oh!

ldorau commented Mar 3, 2026

Uh oh!

lukaszstolarczuk commented Mar 3, 2026

Uh oh!

ldorau commented Mar 3, 2026

Uh oh!

ldorau commented Mar 3, 2026

Uh oh!

ldorau commented Mar 4, 2026

Uh oh!

bratpiorka commented Mar 4, 2026

Uh oh!

adamfidel left a comment

Choose a reason for hiding this comment

Uh oh!

ldorau commented Mar 4, 2026

Uh oh!

ldorau commented Mar 4, 2026

Uh oh!

ldorau commented Mar 5, 2026

Uh oh!

ldorau commented Mar 5, 2026

Uh oh!

ldorau commented Mar 6, 2026

Uh oh!

pbalcer commented Mar 9, 2026

Uh oh!

github-actions bot commented Mar 9, 2026

Uh oh!

lukaszstolarczuk commented Mar 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

ldorau commented Feb 27, 2026 •

edited

Loading