Replace SPIR-V INTEL shuffles with generic version#21416
Open
frengels wants to merge 3 commits intointel:syclfrom
Open
Replace SPIR-V INTEL shuffles with generic version#21416frengels wants to merge 3 commits intointel:syclfrom
frengels wants to merge 3 commits intointel:syclfrom
Conversation
…L, __spirv_SubgroupShuffleDownINTEL and __spirv_SubgroupShuffleUpINT with __spirv_GroupNonUniformShuffle... generic versions.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates SYCL’s SPIR-V shuffle lowering to use the generic __spirv_GroupNonUniformShuffle* builtins instead of the Intel-specific __spirv_SubgroupShuffle*INTEL ones, and adjusts type-traits so vector shuffles are scalarized (per the cited OpenCL subgroup shuffle requirements).
Changes:
- Switch subgroup shuffle implementations to
__spirv_GroupNonUniformShuffle*generic builtins. - Update shuffle type-traits to treat
vecas non-native-shuffle and always scalarize vector shuffles. - Remove the previous Intel-specific “prohibited vector element types” handling and the IGC vector workaround path.
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuation of #14748 (due to inactivity)
Rebased and tested locally
edit: @uditagarwal97