[SYCL] Fix DirectX 11 interop test failures#21430
Open
lbushi25 wants to merge 16 commits intointel:syclfrom
Open
[SYCL] Fix DirectX 11 interop test failures#21430lbushi25 wants to merge 16 commits intointel:syclfrom
lbushi25 wants to merge 16 commits intointel:syclfrom
Conversation
dm-vodopyanov
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
read_write_unsampled.cppimplicitly relies on the assumption that a 2D texture in DirectX 11 has the row major layout in memory. This is because the test, in the absence of a DirectX 11 API to query texture allocation information, attempts to calculate the allocation size of the texture the best it can manually by simply multiplying all the dimensions of the texture. This is then passed to the SYCL external memory import functions to make a SYCL image out of the texture.This assumption, which was not at all mandated by the spec, seems to have fallen apart recently as the layout for a default usage texture in DirectX 11 has been changed to no longer be row major in certain conditions and I suspect this broke many test cases embedded in the test.
This PR attempts to fix this by utilizing the newer DirectX 11.3 API which allows us to explicitly request the textures to be laid out in row major order in memory.