[NewOffloadModel] Remove XFAIL from SYCL E2E tests for the new offloading model#21435
Draft
YixingZhang007 wants to merge 4 commits intointel:syclfrom
Draft
[NewOffloadModel] Remove XFAIL from SYCL E2E tests for the new offloading model#21435YixingZhang007 wants to merge 4 commits intointel:syclfrom
YixingZhang007 wants to merge 4 commits intointel:syclfrom
Conversation
YixingZhang007
force-pushed
the
remove_xfail_new_offload_model
branch
from
cc3a368 to
e1184ac
Compare
YixingZhang007
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removed the XFAIL from two SYCL E2E tests and replaced it with UNSUPPORTED for the new offloading model. The specific changes are below:
AOT/multiple-devices.cppis not supposed to run for the new offloading model. Thus, the XFAIL for the new offloading model is removed and the test is currently marked as UNSUPPORTED.SeparateCompile/test.cpp, becauseclang-offload-bundlershould not be supported for the new offloading model, this test is not supposed to run on the new offloading model. A new testNewOffloadDriver/separate_compile.cppis created specifically for the new offloading model to test compiling device and host code separately.