[SYCL][NewOffloadModel] Add ESIMD Procesing to clang-linker-wrapper.#21449
Open
maksimsab wants to merge 1 commit intointel:syclfrom
Open
[SYCL][NewOffloadModel] Add ESIMD Procesing to clang-linker-wrapper.#21449maksimsab wants to merge 1 commit intointel:syclfrom
maksimsab wants to merge 1 commit intointel:syclfrom
Conversation
maksimsab
force-pushed
the
add_esimd_to_clang_linker_wrapper
branch
from
91961ee to
75e21a3
Compare
maksimsab
commented
Mar 10, 2026
| Settings.GenerateModuleDescWithDefaultSpecConsts = true; | ||
|
|
||
| Settings.SplitMode = Settings.ESIMDOptions.SplitMode = *SYCLModuleSplitMode; | ||
| // TODO: fill AllowDeviceImageDependencies, ESIMDOptions.OptLevel and |
Contributor
Author
There was a problem hiding this comment.
This is left like this because it is more convenient to do when it is moved to clang-sycl-linker.
This patch add getSYCLPostLinkSettings function in clang-linker-wrapper which constructs Settings for SYCLPostLink library. Also, this patch adds an invocation of ESIMD processing in SYCLPostLink library.
maksimsab
force-pushed
the
add_esimd_to_clang_linker_wrapper
branch
from
75e21a3 to
ff5f294
Compare
Comment on lines
+674
to
+678
| /// This function analyzes command line arguments and target triple information | ||
| /// to determine the appropriate settings for the SYCL post-link phase. The | ||
| /// settings control various aspects of device code processing including | ||
| /// specialization constants handling, kernel entry point emission, metadata | ||
| /// generation, and ESIMD code splitting. |
Contributor
There was a problem hiding this comment.
nit - unnecessary words
Suggested change
| /// This function analyzes command line arguments and target triple information | |
| /// to determine the appropriate settings for the SYCL post-link phase. The | |
| /// settings control various aspects of device code processing including | |
| /// specialization constants handling, kernel entry point emission, metadata | |
| /// generation, and ESIMD code splitting. | |
| /// This function analyzes command line arguments and target triple | |
| /// to determine settings for the SYCL post-link phase. The | |
| /// settings control various aspects of device code processing including | |
| /// specialization constants handling, kernel entry point emission, metadata | |
| /// generation, and ESIMD code splitting. |
|
|
||
| if (!Triple.isAMDGCN()) | ||
| Settings.EmitParamInfo = true; | ||
| // Enable program metadata |
Contributor
There was a problem hiding this comment.
nit: unnecessary comment
Suggested change
| // Enable program metadata |
| if (Triple.isNVPTX() || Triple.isAMDGCN() || Triple.isNativeCPU()) | ||
| Settings.EmitProgramMetadata = true; | ||
|
|
||
| // Emit kernel names if we are producing SYCLBIN. |
Contributor
There was a problem hiding this comment.
nit: unnecessary comment just repeating the code
Suggested change
| // Emit kernel names if we are producing SYCLBIN. |
| if (Args.hasArg(OPT_syclbin_EQ)) | ||
| Settings.EmitKernelNames = true; | ||
| // Specialization constant info generation is mandatory - | ||
| // add options unconditionally |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| // add options unconditionally | |
| // add options unconditionally. |
Comment on lines
+722
to
+726
| bool SplitEsimd = | ||
| Args.hasFlag(OPT_sycl_device_code_split_esimd, | ||
| OPT_no_sycl_device_code_split_esimd, SplitEsimdByDefault); | ||
| if (SplitEsimd) | ||
| Settings.ESIMDOptions.SplitESIMD = true; |
Contributor
There was a problem hiding this comment.
nit. SplitEsimd is not used anywhere else. and Settings.ESIMDOptions.SplitESIMD is clear enough, so no need to create temporary SplitEsimd
Suggested change
| bool SplitEsimd = | |
| Args.hasFlag(OPT_sycl_device_code_split_esimd, | |
| OPT_no_sycl_device_code_split_esimd, SplitEsimdByDefault); | |
| if (SplitEsimd) | |
| Settings.ESIMDOptions.SplitESIMD = true; | |
| Settings.ESIMDOptions.SplitESIMD = Args.hasFlag(OPT_sycl_device_code_split_esimd, | |
| OPT_no_sycl_device_code_split_esimd, SplitEsimdByDefault); |
| if (SplitEsimd) | ||
| Settings.ESIMDOptions.SplitESIMD = true; | ||
|
|
||
| Settings.ESIMDOptions.LowerESIMD = true; |
Contributor
There was a problem hiding this comment.
nit: here comment would be useful to explain why LowerESIMD setting is set to true unconditionally.
YuriPlyakhin
approved these changes
Mar 10, 2026
Contributor
YuriPlyakhin
left a comment
YuriPlyakhin
left a comment
There was a problem hiding this comment.
LGTM. several nits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch add getSYCLPostLinkSettings function in clang-linker-wrapper
which constructs Settings for SYCLPostLink library. Also, this patch adds
an invocation of ESIMD processing in SYCLPostLink library.